16 replies [Last post]
t-bone_two
t-bone_two's picture
Offline
Enthusiast
Los Angeles
Last seen: 3 years 51 weeks ago
Los Angeles
Timezone: GMT-6
Joined: 2009-09-26
Posts: 209
Points: 268

The primary code base has been built.

Much of the rest will be jquery integration.

I would appreciate a second set of eyes on any part. From the code to the presentation.

Thank you so much for your time.

CLICK HERE TO GO TO SITE

CupidsToejam
CupidsToejam's picture
Offline
Guru
Florida
Last seen: 4 years 13 weeks ago
Florida
Timezone: GMT-4
Joined: 2008-08-15
Posts: 2637
Points: 1556

1. surely you can fix that

1. surely you can fix that one validation error on the main page.

2. not SEO friendly

3. seems you went a little crazy with your divs.

4. br tags, really?

5. i would have made the social media, a list.

6. I dont understand the site, its confusing. Whats is it's purpose? whats it do? These are not questions you want viewers to be asking themselves.

This site is incomplete. "Site Checks" is for sites that are ready for deployment.

t-bone_two
t-bone_two's picture
Offline
Enthusiast
Los Angeles
Last seen: 3 years 51 weeks ago
Los Angeles
Timezone: GMT-6
Joined: 2009-09-26
Posts: 209
Points: 268

Thanks

Thanks for the reply.

I imagine your a joy to work with. Smile

Verschwindende
Verschwindende's picture
Offline
Guru
Last seen: 35 weeks 6 days ago
Timezone: GMT-4
Joined: 2009-10-09
Posts: 2040
Points: 2262

Why are you using "I" in all

Why are you using "I" in all the lists??

t-bone_two
t-bone_two's picture
Offline
Enthusiast
Los Angeles
Last seen: 3 years 51 weeks ago
Los Angeles
Timezone: GMT-6
Joined: 2009-09-26
Posts: 209
Points: 268

I would like more info

Actually. I would like more info on that one. I have tried using borders before. Which I believe is the correct way to do it. But if I do border-right-style:solid; or border-left-style:solid; on the li. Then it puts a hash mark on the far left side or far right side of the list I do not want there.

I would love more info on the best method and for you to share your expertise in that situation if you do not mind. I would be in your debt.

Thanks!!

gary.turner
gary.turner's picture
Offline
Moderator
Dallas
Last seen: 9 hours 35 min ago
Dallas
Timezone: GMT-6
Joined: 2004-06-25
Posts: 9745
Points: 3824

Markup needs improvement

Why the h2 headings in the menus? Those aren't heading, they're simply list items; links. If you think Google will love you for it, it ain't happenin'.

Those "|" separators are not list items; lose them. Use a left border on each li, except the first: li:first-child {border: none;}. Use padding to control spacing.

Mark up the paragraphs as p elements; do not use br elements for that purpose. Also, don't use br for spacing; use margins or padding, as appropriate.

Quote:

I imagine your[sic] a joy to work with.

Please, that's beside the point. He gave you his time to critique your site. Don't complain that you don't like the tone. See ESR's On Not Reacting Like A Loser. Don't get your tighty whities in a twist over this either. Eric and Rick have maintained the article for many years, because it represents the right way to get the most benefit from online communities.

cheers,

gary

If your web page is as clever as you can make it, it's probably too clever for you to debug or maintain.

t-bone_two
t-bone_two's picture
Offline
Enthusiast
Los Angeles
Last seen: 3 years 51 weeks ago
Los Angeles
Timezone: GMT-6
Joined: 2009-09-26
Posts: 209
Points: 268

Thanks

I appreciate your time.

And thank you for elaborating on that information.

I was unable to follow the initial comments and recommendations as now I see they were beneficial. But I was unable to extract the meaning regarding where the problem resided in the methodology.

I had gotten similar feedback a while back regarding <br> and I was unable to follow it because it lacked context. I ended up switching everything to <br /> to see if that was what was being referred and it ended up causing a bunch of validation errors.

And the social media has always been in a list.

And in terms of SEO. The logical way to handle that in my opinion is doing so at the end. Because the content dictates the appropriate keywords.

Giving some of the recommendations were made including parts of the code structure that matched his recommendations I assumed a degree of sarcasm.

Thanks for your time!

thepineapplehead
thepineapplehead's picture
Offline
Guru
Last seen: 1 year 16 weeks ago
Timezone: GMT+1
Joined: 2004-06-30
Posts: 9668
Points: 801

Why is 90% of the site taken

Why is 90% of the site taken up by a flash file that tells me nothing?

Verschwindende wrote:
  • CSS doesn't make pies

t-bone_two
t-bone_two's picture
Offline
Enthusiast
Los Angeles
Last seen: 3 years 51 weeks ago
Los Angeles
Timezone: GMT-6
Joined: 2009-09-26
Posts: 209
Points: 268

Because the Client Said So

Web is subjective. Mood, tone and entertainment are communicated in ways other than static text and artwork.

The clothing line is selling reflective clothing to the Jewish Orthodox community to wear on the way to temple and during bad weather . . .

So the weather plays a role as does sunset. Because the attire of the orthodox community is predominantly solid black.

Vade
Vade's picture
Offline
Enthusiast
Ireland
Last seen: 9 years 1 week ago
Ireland
Joined: 2007-08-13
Posts: 315
Points: 276

I get that you client wanted

I get that you client wanted the flash file but TPH is right, it doesn't say anything, I've sat watching it for a while now (the clouds started making me nauseous) and there's nothing about it that says "we sell clothing" it's just a fast setting sun.

The site navigation looks like an after thought, its down under everything else and in a smaller font than the page content, it seems like a secondary navigation.

If the flash has to remain why not overlay the content? That way you get to have the flash and when someone hits the site they may have a clue what's going on.

CupidsToejam
CupidsToejam's picture
Offline
Guru
Florida
Last seen: 4 years 13 weeks ago
Florida
Timezone: GMT-4
Joined: 2008-08-15
Posts: 2637
Points: 1556

Ah, the flash wasnt there

Ah, the flash wasnt there when I first reviewed the site. Great addition and dont let these know-it-all's tell you otherwise. I'm a huge Flash fan!!

Party

Hugo
Hugo's picture
Offline
Moderator
London
Last seen: 4 years 48 weeks ago
London
Joined: 2004-06-06
Posts: 15668
Points: 2806

flursh oh gawd help us (

flursh oh gawd help us Sad(

Before you make your first post it is vital that you READ THE POSTING GUIDELINES!
----------------------------------------------------------------
Please post ALL your code - both CSS & HTML - in [code] tags
Please validate and ensure you have included a full Doctype before posting.
Why validate? Read Me

gary.turner
gary.turner's picture
Offline
Moderator
Dallas
Last seen: 9 hours 35 min ago
Dallas
Timezone: GMT-6
Joined: 2004-06-25
Posts: 9745
Points: 3824

No point

The client may want it, but it's your job to stop him from doing something silly, like taking up most of the page with a boring flash animation instead of getting his message out. Maybe he just likes those dirty, nasty, noisome grackles. If you just must do it, at least make the width a reasonable value. There is no sane reason for it to be 2000px wide.

cheers,

gary

If your web page is as clever as you can make it, it's probably too clever for you to debug or maintain.

t-bone_two
t-bone_two's picture
Offline
Enthusiast
Los Angeles
Last seen: 3 years 51 weeks ago
Los Angeles
Timezone: GMT-6
Joined: 2009-09-26
Posts: 209
Points: 268

Actual Question

Do you know a way to get rid of the vertical scroll bar without using position fixed?

gary.turner
gary.turner's picture
Offline
Moderator
Dallas
Last seen: 9 hours 35 min ago
Dallas
Timezone: GMT-6
Joined: 2004-06-25
Posts: 9745
Points: 3824

Huh?

You make the page extend less than the height of the browser viewport. Did you mean the horizontal scrollbar? Make that flash animation no wider than about 760px ought to do it.

cheers,

gary

If your web page is as clever as you can make it, it's probably too clever for you to debug or maintain.

t-bone_two
t-bone_two's picture
Offline
Enthusiast
Los Angeles
Last seen: 3 years 51 weeks ago
Los Angeles
Timezone: GMT-6
Joined: 2009-09-26
Posts: 209
Points: 268

Yes But

Yes, but then the animation drops off. I want it to play about 2,000px wide. Without scroll bars would be nice.

aqua
aqua's picture
Offline
newbie
UK
Last seen: 6 years 32 weeks ago
UK
Timezone: GMT+1
Joined: 2010-06-24
Posts: 5
Points: 6

Nive background animation BUT

Nive background animation BUT all your content is below the fold, so you have to scroll down to find it, that really spoils it for me.

Also the footer links are black on black, so very difficult to see, search engines may even view that as hidden links ?