9 replies [Last post]
t-bone_two
t-bone_two's picture
Offline
Enthusiast
Los Angeles
Last seen: 4 years 40 weeks ago
Los Angeles
Timezone: GMT-6
Joined: 2009-09-26
Posts: 209
Points: 268

I am just finishing up the structure of my new project. That I feel is some of my best work yet.

The index and a couple other pages are the only ones up.

Any feedback or do you see any errors on your end?

Thanks so much!

ARSENAL RECORDS

CupidsToejam
CupidsToejam's picture
Offline
Guru
Florida
Last seen: 5 years 2 weeks ago
Florida
Timezone: GMT-4
Joined: 2008-08-15
Posts: 2637
Points: 1556

1. t-bone, after so many

1. t-bone, after so many posts, you should understand how important valid code is. Validate the code.

2. Its not SEO friendly

3.

<div id = "bar_one"></div>
Its good practice to not use spaces.

4. #float_elements should be there. You should just apply a repeating body background to achieve this.

5. <BR><BR>
Whats up with the tacky br tags? Also, they should be closed, and lower-case.

6.

<div class = "company_profile"><span class = "white"><a href = "profile.html">COMPANY PROFILE</a><BR><a href = "site_001/index.html">Previous Site</a></span></div>
Do we really need all these divs and spans for two links? Why dont just style the href tag itself?

7. does

really need to be there?

8. why does YouTube logo have its own div? just style the img tag. You have alot of this going on all over the place. Plz concider reading up on this infectious disease called divitis.

9. More br tag misuse.

10. quick_links should be a list

11. #icons should be a list

12. track listing should be a list.

13. LINKS should be a list

Okay, now on to design...

14. why use a background, if we're never going to really see it? bar_two.jpg

15. put your player inside #header.

16. Does your nav need to be so wide?

17. large_sale_icons should be a list

18. I dont like the design, nothing flows easy. its hard to scan.

If you take my comments into consideration, you have work ahead of you. But plz, do not take my critique to heart. its only constructive criticism to help you along. And its okay to disagree.

rhenry
rhenry's picture
Offline
Regular
st. louis, MO
Last seen: 10 years 26 weeks ago
st. louis, MO
Timezone: GMT-5
Joined: 2010-01-28
Posts: 17
Points: 21

It looks pretty good to me.

It looks pretty good to me. The only thing I would say is that (using Firefox) it's kind of weird that when I click in the text boxes at the top right, in order to join the mailing list, the words "last name", "first name" and "email" don't disappear for me. So I have to either ctrl + a, or backspace or use my mouse, etc. to remove them first, which might translate as 'work' to a lot of people and they won't like it.

rhenry
rhenry's picture
Offline
Regular
st. louis, MO
Last seen: 10 years 26 weeks ago
st. louis, MO
Timezone: GMT-5
Joined: 2010-01-28
Posts: 17
Points: 21

CupidsToejam wrote: 1.

CupidsToejam wrote:

1. t-bone, after so many posts, you should understand how important valid code is. Validate the code.

2. Its not SEO friendly

3.

<div id = "bar_one"></div>
Its good practice to not use spaces.

4. #float_elements should be there. You should just apply a repeating body background to achieve this.

5. <BR><BR>
Whats up with the tacky br tags? Also, they should be closed, and lower-case.

6.

<div class = "company_profile"><span class = "white"><a href = "profile.html">COMPANY PROFILE</a><BR><a href = "site_001/index.html">Previous Site</a></span></div>
Do we really need all these divs and spans for two links? Why dont just style the href tag itself?

7. does

really need to be there?

8. why does YouTube logo have its own div? just style the img tag. You have alot of this going on all over the place. Plz concider reading up on this infectious disease called divitis.

9. More br tag misuse.

10. quick_links should be a list

11. #icons should be a list

12. track listing should be a list.

13. LINKS should be a list

Okay, now on to design...

14. why use a background, if we're never going to really see it? bar_two.jpg

15. put your player inside #header.

16. Does your nav need to be so wide?

17. large_sale_icons should be a list

18. I dont like the design, nothing flows easy. its hard to scan.

If you take my comments into consideration, you have work ahead of you. But plz, do not take my critique to heart. its only constructive criticism to help you along. And its okay to disagree.

I like your honesty. Very good post.

CupidsToejam
CupidsToejam's picture
Offline
Guru
Florida
Last seen: 5 years 2 weeks ago
Florida
Timezone: GMT-4
Joined: 2008-08-15
Posts: 2637
Points: 1556

Quote: 4. #float_elements

Quote:

4. #float_elements should be there. You should just apply a repeating body background to achieve this.

Ok, i meant to say #float_elements should not be there.

t-bone_two
t-bone_two's picture
Offline
Enthusiast
Los Angeles
Last seen: 4 years 40 weeks ago
Los Angeles
Timezone: GMT-6
Joined: 2009-09-26
Posts: 209
Points: 268

Nah man. I don't take

Nah man. I don't take anything personally at all. I appreciate your time. And I always take into consideration that someone took the time to give me a critique and at length so I appreciate it.

The code validated upon the first round completion.

1. The area that is not. Is the area where I paid a guy to make the email form work. Also the h1, 2 and 3 tags. With their removal it will validate.

I do need to re-structure those tags. But they are there for the doc structure. And I am learning how to do that correctly. But I am seeing results via the validator.

2. Good eye on the meta data. It has not been added.

3. I don't see the space in the code.

4. Repeating the body background is a good point. I originally started with the 100% containers then re-margined the body container over them. But for the most part I am reasonably happy with it. Primarily because the bottom is working as an accordian.

5. You know. It is funny you mention that. Because using the strict doc type. The actual suggestion I got by validating it was actually Line Break. and also the research I have read regarding strict doc types says you do not close a br tag

6. Quick links is not a list because it was not feasible to the doc structure with those backgrounds at 100% length.

7. icons are not a list because they are a child of "sections". And sections has the li styles controlling the sections below. Though if I thought the difference would be detrimental I would pull it out and re-structure it.

8. The reason youtube has it's own div tag is because the square album cover overlaps and lays on top and spans 3 vertical blocks.

9. I am willing to agree with you on the track listing and such. And I may restructure that aspect. So thanks for the advice.

14. why use a background, if we're never going to really see it? bar_two.jpg
(Because there are people with monitors larger than that of a laptop.)

15. Player did not work in #header.

16. Does your nav need to be so wide? (Not sure which nav.) The entire presentation is about 900px. I know the 800 600 least common denominator. But I did not find it suitable for this presentation.

18. I dont like the design, nothing flows easy. its hard to scan.
To each his own. It is the one the client liked. And we spent alot of time researching market trends.

Thanks for your time.

t-bone_two
t-bone_two's picture
Offline
Enthusiast
Los Angeles
Last seen: 4 years 40 weeks ago
Los Angeles
Timezone: GMT-6
Joined: 2009-09-26
Posts: 209
Points: 268

Thanks!

Thanks so much for your time!!

t-bone_two
t-bone_two's picture
Offline
Enthusiast
Los Angeles
Last seen: 4 years 40 weeks ago
Los Angeles
Timezone: GMT-6
Joined: 2009-09-26
Posts: 209
Points: 268

Gave it Some Though

Ok

I thought over your posting. Initially I was a bit irritated because of the time that would be involved.

None the less. I give it to you. You gave me a new set of eyes. I walked away for an hour and thought it over.

The bottom is not well structured. The top needs some work also.

What hit home the most was your reccommendations regarding the track listing. So I went back to the drawing board.

What do you think of this track listing?

I no longer see an option to attach a file. I will start a new thread.

CupidsToejam
CupidsToejam's picture
Offline
Guru
Florida
Last seen: 5 years 2 weeks ago
Florida
Timezone: GMT-4
Joined: 2008-08-15
Posts: 2637
Points: 1556

Quote: What do you think of

Quote:

What do you think of this track listing?

Well, its not a nice clean UL list. Its messy. Why do you have it all inside an H3 tag?

t-bone_two
t-bone_two's picture
Offline
Enthusiast
Los Angeles
Last seen: 4 years 40 weeks ago
Los Angeles
Timezone: GMT-6
Joined: 2009-09-26
Posts: 209
Points: 268

Not what I mean

I couldnt attach a file. It is just the layout. It is. In a thread called "track listin)