10 replies [Last post]
Jarritos
Offline
Regular
Last seen: 15 years 7 weeks ago
Timezone: GMT-8
Joined: 2005-09-06
Posts: 13
Points: 0

This is the first time I have tried using CSS so the code I bet is really sloppy but any sort of help on what needs to be tuned up or any advice on something I did where maybe there is a better way is greatly appreciated.

http://movie-gurus.com/test/2/index.php

Thanks
David

Tyssen
Tyssen's picture
Offline
Moderator
Brisbane
Last seen: 6 years 1 week ago
Brisbane
Timezone: GMT+10
Joined: 2004-05-01
Posts: 8201
Points: 1386

My First .CSS Site

If you're serious about building a CSS site, you'll add a doctype to your page and then run the W3C Validator - at the moment you have 72 errors.

How to get help
Post a link. If you can't post a link, jsFiddle it.
My blog | My older articles | CSS Reference

Jarritos
Offline
Regular
Last seen: 15 years 7 weeks ago
Timezone: GMT-8
Joined: 2005-09-06
Posts: 13
Points: 0

My First .CSS Site

thanks
what does it mean when it says:

Line: 333 Context : input , textarea
Invalid number : color e07a06 is not a color value : e07a06

and

Line : 20 font-family: You are encouraged to offer a generic family as a last alternative

Tyssen
Tyssen's picture
Offline
Moderator
Brisbane
Last seen: 6 years 1 week ago
Brisbane
Timezone: GMT+10
Joined: 2004-05-01
Posts: 8201
Points: 1386

My First .CSS Site

Jarritos wrote:

Line: 333 Context : input , textarea
Invalid number : color e07a06 is not a color value : e07a06
Line : 20 font-family: You are encouraged to offer a generic family as a last alternative

Without checking your code, I'd guess the first one is cos you've left # off the hex number and the second one is cos you should end your font-family declaration with either serif or sans-serif.

How to get help
Post a link. If you can't post a link, jsFiddle it.
My blog | My older articles | CSS Reference

Jarritos
Offline
Regular
Last seen: 15 years 7 weeks ago
Timezone: GMT-8
Joined: 2005-09-06
Posts: 13
Points: 0

My First .CSS Site

thanks fixed that

the rest of the check errors are

document type does not allow element "UL" here; missing one of "APPLET", "OBJECT", "MAP", "IFRAME", "BUTTON" start-tag.

except with ul as different things what does this mean.

also if there are any other suggestions on how to make my coding better please feel free to tell me

wolfcry911
wolfcry911's picture
Offline
Guru
MA, USA
Last seen: 6 years 33 weeks ago
MA, USA
Timezone: GMT-5
Joined: 2004-09-01
Posts: 3224
Points: 237

My First .CSS Site

you haven't closed the h2 tag above the ul. And it looks as though it should be a p tag anyway. In 4.01 transitional, iirc, some tags may be left unclosed (like the p tag) but others must be closed. You really ought to get in the habit of closing all your tags anyway.

Hugo
Hugo's picture
Offline
Moderator
London
Last seen: 5 years 41 weeks ago
London
Joined: 2004-06-06
Posts: 15668
Points: 2806

My First .CSS Site

A few things,

It's better to try and keep your overall design width to under 1000px preferably design for 800px resolutions.

optimize your images: your page as is far too slow in rendering, not everyone has broadband. Images of 79k are far too large and the animated gif at 400k is just not worth the wait, this is a twofold problem it's tedious for people waiting and consumes your bandwidth.

You need to get out of the habit of thinking that an h# element is a structural container it's for holding heading text, using it to wrap a table in is pointless and wrong.

Hugo.

Before you make your first post it is vital that you READ THE POSTING GUIDELINES!
----------------------------------------------------------------
Please post ALL your code - both CSS & HTML - in [code] tags
Please validate and ensure you have included a full Doctype before posting.
Why validate? Read Me

Jarritos
Offline
Regular
Last seen: 15 years 7 weeks ago
Timezone: GMT-8
Joined: 2005-09-06
Posts: 13
Points: 0

My First .CSS Site

Quote:
you haven't closed the h2 tag above the ul. And it looks as though it should be a p tag anyway. In 4.01 transitional, iirc, some tags may be left unclosed (like the p tag) but others must be closed.


I still don't get it i closed my h2 tag down a little more and the ul indents it while the p just spaces it so why would i use the p instead of the ul?

Quote:
You need to get out of the habit of thinking that an h# element is a structural container it's for holding heading text, using it to wrap a table in is pointless and wrong.


i don't understand what you mean by this. how else would i do it?

also what is the best way to reduce the size of the images program wise?

Hugo
Hugo's picture
Offline
Moderator
London
Last seen: 5 years 41 weeks ago
London
Joined: 2004-06-06
Posts: 15668
Points: 2806

My First .CSS Site

I think Wolfcry was referring to the fact that the text before the ul should really be a paragraph <p> you shouldn't wrap those elements in a header. A header may contain things such as image tags or anchors but not groups of elements such as that. Loose the h3 and enclose the text in a <p> and leave the ul to follow bellow, likewise your use of an h3 tag to hold the table is unnecessary the table will stand on it's own.

Your use of the h1 headings is ok but for that fact that one should restrict the use of h1 headers to once only per page really, they would be better as h2 or h3.

Optimizing graphics is a function of all decent graphics programes and you should find options when you save the file.

Hugo.

Before you make your first post it is vital that you READ THE POSTING GUIDELINES!
----------------------------------------------------------------
Please post ALL your code - both CSS & HTML - in [code] tags
Please validate and ensure you have included a full Doctype before posting.
Why validate? Read Me

breitinger
Offline
newbie
iowa
Last seen: 15 years 6 weeks ago
iowa
Timezone: GMT-6
Joined: 2005-09-08
Posts: 3
Points: 0

My First .CSS Site

minor issue: the copyright symbol along the bottom is incorrect, not sure how to fix it, should be simple to find out though.

best of luck
ps. love the layout

n8gz4ez
n8gz4ez's picture
Offline
Leader
Last seen: 11 years 38 weeks ago
Timezone: GMT-6
Joined: 2005-06-13
Posts: 802
Points: 0

My First .CSS Site

This is my big chance . . . yep, I blew it . . .