9 replies [Last post]
zen_warrior
zen_warrior's picture
Offline
newbie
rochester, ny
Last seen: 16 years 10 weeks ago
rochester, ny
Joined: 2005-05-19
Posts: 10
Points: 0

I picked up Web Standards Solutions by Dan Cederholm and tried to use that as a starting point for reworking my site using CSS. For layout purposes, I'm a CSS novice.

Can I get some feedback on not only the design but source and CSS if possible? Here is the URL: http://www.letsgomurphys.com/

Thanks in advance.

-Mike

Tyssen
Tyssen's picture
Offline
Moderator
Brisbane
Last seen: 6 years 41 weeks ago
Brisbane
Timezone: GMT+10
Joined: 2004-05-01
Posts: 8201
Points: 1386

My first foray into CSS layout, any thoughts?

I think it's looking pretty good. Your header graphic is great.
Other pages of your site have little graphics in the content area and I think you could do with some on your home page. Your home page should be as striking, if not more so, than your other pages, and it's not at the moment.
In 'About Michael', you could get the bulleted items to indent properly.
In 'Dailies' I think your calendar could do with a bit more space around it and the grey line could run the whole length of the content area.
'Contact' needs something else to help pad it out. It kinda looks odd with the header overpowering the actual content on that page.
All the pages could do with a little more padding at the bottom of the window.
But, generally, very nice job - just a few little tweaks here and there.

How to get help
Post a link. If you can't post a link, jsFiddle it.
My blog | My older articles | CSS Reference

xaphalanx
xaphalanx's picture
Offline
Enthusiast
Last seen: 16 years 7 weeks ago
Joined: 2005-06-06
Posts: 64
Points: 0

My first foray into CSS layout, any thoughts?

From one CSS noobie to another very nicely done!

Anonymous
Anonymous's picture
Guru

My first foray into CSS layout, any thoughts?

I don't have an explanation but the navigation is broken in Safari 1.3

See attachment:

zen_warrior
zen_warrior's picture
Offline
newbie
rochester, ny
Last seen: 16 years 10 weeks ago
rochester, ny
Joined: 2005-05-19
Posts: 10
Points: 0

My first foray into CSS layout, any thoughts?

I appreciate everyone's feedback, thank you.

Thanks, Triumph, I'll look into the Safari thing.

-Edited...Wow, I didn't look at your attachment until after I posted this reply. It's totally broken in Safari. Can anybody offer any suggestions?

-Mike

Anonymous
Anonymous's picture
Guru

My first foray into CSS layout, any thoughts?

zen_warrior wrote:
Wow, I didn't look at your attachment until after I posted this reply. It's totally broken in Safari. Can anybody offer any suggestions?
Looks like it is the comments that is causing the problem in Safari:
	/*width: 99px; /* for IE/Win */ */
It seems they are nested and it doesn't work like that. Smile

The first */ closes the first /* which leaves the last */ hanging and it seems to mess up the next line.

Anyway, if you take out those comments or rewrite them as

	/*width: 99px; */ /* for IE/Win */ 

it works just fine. Smile

zen_warrior
zen_warrior's picture
Offline
newbie
rochester, ny
Last seen: 16 years 10 weeks ago
rochester, ny
Joined: 2005-05-19
Posts: 10
Points: 0

My first foray into CSS layout, any thoughts?

Thanks again Triumph.

I originally had some notes to myself commented out on those lines and then I guess I just ended up commenting out the entire line.

I think if you try it in Safari now it should be good.

-Mike

Anonymous
Anonymous's picture
Guru

My first foray into CSS layout, any thoughts?

zen_warrior wrote:
I think if you try it in Safari now it should be good.
Yep, yep! Good show! Nice work.

n8gz4ez
n8gz4ez's picture
Offline
Leader
Last seen: 12 years 26 weeks ago
Timezone: GMT-6
Joined: 2005-06-13
Posts: 802
Points: 0

My first foray into CSS layout, any thoughts?

If you click from the Dailies to the Contact button, the positioning moves instead of saying put because in FF correctly hides the scrollbar if it is not needed. If you want to force the scrollbar you might want to try the following:

HTML below the body:

 
<div id="scroll"></div> 

CSS
 
#scroll { 
   bottom: -0.1px; 
   position: absolute; 
   top: 0; 
   width: 1em; 
   z-index: -1; 
} 

I am not sure if this semantically right, or how it works honestly; I just know that it does the job.

This is my big chance . . . yep, I blew it . . .

mindsoul
mindsoul's picture
Offline
Regular
italy
Last seen: 16 years 13 weeks ago
italy
Joined: 2005-04-26
Posts: 18
Points: 0

My first foray into CSS layout, any thoughts?

very nice colors and the image too.

1.choose a smaller size for the header because in a 800x600 resolution ocupates more than a half screen.
2. as i see you have pages smallers than one screen, in cases like this you must give from your css file a minimum heigh to the box element.