10 replies [Last post]
DavidRhodes
Offline
Regular
Leeds, UK
Last seen: 12 years 34 weeks ago
Leeds, UK
Joined: 2004-11-25
Posts: 20
Points: 0

findthatpart.co.uk

Critisise away Laughing out loud any good/bad practices i've used etc etc....

briski
briski's picture
Offline
Elder
London
Last seen: 8 years 19 weeks ago
London
Timezone: GMT+1
Joined: 2004-02-16
Posts: 1066
Points: 0

Site check: findthatpart.co.uk

I notice that scriptless folk are told that their browser might not support JavaScript and you reccomend to "Upgrade your Web browser to a newer version. We recommend Internet Explorer 5.0 or above."

Is this a joke? Wink

Also on a more serious note you are using a background image for you logo - I would say that this is not approptiate, background images are for images that have no real meaning, decoration. Your logo not only has meaning but also text. By using a background you are displaying informaiton that only a sub section of people ever stand a chance to see.

On your search box, the use of Javascript with the onchange event on the dropdowns is effectively preventing keyboard navigation and is not all that nice a practice.

Infact looking at things I really don't see why you are relying on JS for the whole thing to work, is it just to have the dynamic forms?

Other than that it's a nice clean look! Smile

DavidRhodes
Offline
Regular
Leeds, UK
Last seen: 12 years 34 weeks ago
Leeds, UK
Joined: 2004-11-25
Posts: 20
Points: 0

Site check: findthatpart.co.uk

Yeah, need to update that NOSCRIPT text Laughing out loud

Thanks for the info on the title image.

The javascript is needed to populate the lower boxes, ie, select a make and the appropriate models are loaded

briski
briski's picture
Offline
Elder
London
Last seen: 8 years 19 weeks ago
London
Timezone: GMT+1
Joined: 2004-02-16
Posts: 1066
Points: 0

Site check: findthatpart.co.uk

Yes I know that what you're using it for - but do you really need it I mean.

By using the Javascript in this way you are excluding anyone who does not use a mouse and/or who has JS turned off for what ever reason.

Ideally dropdown boxes should be accompanied with submit buttons, in this way your site would be more usable to different people/browsers but would loose no functionality.

Of course this would involve adding buttons and extra work so you might just want to not I guess. Wink

thepineapplehead
thepineapplehead's picture
Offline
Guru
Last seen: 31 weeks 16 hours ago
Joined: 2004-06-30
Posts: 9668
Points: 801

Site check: findthatpart.co.uk

This is the reason I use JS sparingly.

Quote:
Solution: Follow these instructions to enable JavaScript on Internet Explorer:

If you insist on this message, you should at least be cross-browser friendly.

Verschwindende wrote:
  • CSS doesn't make pies

DavidRhodes
Offline
Regular
Leeds, UK
Last seen: 12 years 34 weeks ago
Leeds, UK
Joined: 2004-11-25
Posts: 20
Points: 0

Site check: findthatpart.co.uk

Come on, this is a CSS forum, I want to know if my CSS is up to scratch, I know i'm using JavaScript and for the time been, that won't change.

rmfred
rmfred's picture
Offline
Elder
Rock Springs, WY
Last seen: 2 years 2 weeks ago
Rock Springs, WY
Timezone: GMT-6
Joined: 2004-01-31
Posts: 1073
Points: 31

Site check: findthatpart.co.uk

Quote:
Come on, this is a CSS forum, I want to know if my CSS is up to scratch

It doesn't validate Smile there are some minor errors

DavidRhodes
Offline
Regular
Leeds, UK
Last seen: 12 years 34 weeks ago
Leeds, UK
Joined: 2004-11-25
Posts: 20
Points: 0

Site check: findthatpart.co.uk

Doesn't it? Thought i'd checked most pages, which page doesn't validate.

cheers Laughing out loud

rmfred
rmfred's picture
Offline
Elder
Rock Springs, WY
Last seen: 2 years 2 weeks ago
Rock Springs, WY
Timezone: GMT-6
Joined: 2004-01-31
Posts: 1073
Points: 31

Site check: findthatpart.co.uk

rmfred
rmfred's picture
Offline
Elder
Rock Springs, WY
Last seen: 2 years 2 weeks ago
Rock Springs, WY
Timezone: GMT-6
Joined: 2004-01-31
Posts: 1073
Points: 31

Site check: findthatpart.co.uk

In case you're interested...
Links, seller directory, search all have html errors

I like the design and color scheme of the site... except the blue text.. not fond of that but that's just me...

DavidRhodes
Offline
Regular
Leeds, UK
Last seen: 12 years 34 weeks ago
Leeds, UK
Joined: 2004-11-25
Posts: 20
Points: 0

Site check: findthatpart.co.uk

cheers for the comments, i'll look at the css bugs.