12 replies [Last post]
larmyia
Offline
Elder
London
Last seen: 12 years 1 week ago
London
Timezone: GMT+1
Joined: 2005-01-25
Posts: 1060
Points: 0

Hi, Finally have managed to finish my site enough to get some critique. I am sure there are many issues, but it's my first attempt at handcoding, css, and tableless design. any constructive criticism would be much appreciate (on the design or the code).

www.tonylacey.com

thanks

larmyia

thepineapplehead
thepineapplehead's picture
Offline
Guru
Last seen: 26 weeks 5 days ago
Joined: 2004-06-30
Posts: 9668
Points: 801

1st CSS Tableless Site - views appreciated

From a code point of view, it's very clean, simple, well laid out. Good job.

However, you could sort out the footer so the float: right; is controlled by the css file.

From a design point of view, I dislike the navigation - it's not so much the letter spacing (which could be reduced a shade), it's the font. Not sure what the problem is, but it doesn't look right.

Verschwindende wrote:
  • CSS doesn't make pies

Anonymous
Anonymous's picture
Guru

1st CSS Tableless Site - views appreciated

<span id="copy">&copy; 2004</span> You've been working on it for quite some time, eh? Wink

larmyia
Offline
Elder
London
Last seen: 12 years 1 week ago
London
Timezone: GMT+1
Joined: 2005-01-25
Posts: 1060
Points: 0

1st CSS Tableless Site - views appreciated

Triumph wrote:
<span id="copy">&copy; 2004</span> You've been working on it for quite some time, eh? Wink

LOL you got me there! Once I had a better understanding of CSS realised I had to handcode it really, then take out the tables, then develop it in FF as opposed to IE, then...you get the picture. Smile

TPH: thanks Smile much appreciated. I have sorted out the footer thing and put it in my css. not sure what you mean about the nav, but will try out some diff fonts and see if they look any better. but thanks for the input!

antibland
antibland's picture
Offline
Leader
Pittsburgh
Last seen: 11 years 37 weeks ago
Pittsburgh
Joined: 2005-01-17
Posts: 603
Points: 0

the nav

Quote:
From a design point of view, I dislike the navigation - it's not so much the letter spacing (which could be reduced a shade), it's the font. Not sure what the problem is, but it doesn't look right.

I echo thepineapplehead's comment. I think that the nav is a bit too understated when compared to the header (tonylacey.com). The header is very dominant in the design and the nav is visually snuffed because of it. I understand that the main header should be more noticeable (usually) than the nav, but the nav needs to have more clout than it currently has. Having said that, I don't know how to make this happen. I'm just trying to get to the root of the problem.

thepineapplehead
thepineapplehead's picture
Offline
Guru
Last seen: 26 weeks 5 days ago
Joined: 2004-06-30
Posts: 9668
Points: 801

1st CSS Tableless Site - views appreciated

I think the problem lies in the fact that the header is below the navigation.

It's not bad, I just think the font is too . . . thin. Maybe bold it? Or pick a different font?

Verschwindende wrote:
  • CSS doesn't make pies

antibland
antibland's picture
Offline
Leader
Pittsburgh
Last seen: 11 years 37 weeks ago
Pittsburgh
Joined: 2005-01-17
Posts: 603
Points: 0

1st CSS Tableless Site - views appreciated

thepineapplehead, you're pretty bright for a fruit Wink . larmyia, if you're struggling with fonts, be sure to read this:

http://www.alistapart.com/articles/dynatext/

A demo of this article's code is here:

http://www.stewartspeak.com/dtr/demo/

You're almost there...

larmyia
Offline
Elder
London
Last seen: 12 years 1 week ago
London
Timezone: GMT+1
Joined: 2005-01-25
Posts: 1060
Points: 0

Re: the nav

antibland wrote:
I echo thepineapplehead's comment. I think that the nav is a bit too understated when compared to the header (tonylacey.com). The header is very dominant in the design and the nav is visually snuffed because of it. I understand that the main header should be more noticeable (usually) than the nav, but the nav needs to have more clout than it currently has. Having said that, I don't know how to make this happen. I'm just trying to get to the root of the problem.

I see what you guys mean...I've tried a couple of things. what do you think of this? I'm not convinced.

www.tonylacey.com

antibland - the link was v interesting...will investigate further.

thanks

larmyia

thepineapplehead
thepineapplehead's picture
Offline
Guru
Last seen: 26 weeks 5 days ago
Joined: 2004-06-30
Posts: 9668
Points: 801

1st CSS Tableless Site - views appreciated

Much nicer, although I think the uppercase on the current link is unnecessary. The logo and the rest of the links are lowercase, I think maybe the current link should just be red.

Quote:
thepineapplehead, you're pretty bright for a fruit

Thanks!

Verschwindende wrote:
  • CSS doesn't make pies

seb
Offline
Enthusiast
Last seen: 13 years 34 weeks ago
Joined: 2003-09-20
Posts: 208
Points: 0

1st CSS Tableless Site - views appreciated

it's the inconsistency in spacing in the nav that really bugs me, sort that pipe out! Smile

larmyia
Offline
Elder
London
Last seen: 12 years 1 week ago
London
Timezone: GMT+1
Joined: 2005-01-25
Posts: 1060
Points: 0

1st CSS Tableless Site - views appreciated

seb wrote:
sort that pipe out! Smile

pipe? you lost me there!

tho I know what ur saying about the nav spacing.

tph: thanks!

larmyia

seb
Offline
Enthusiast
Last seen: 13 years 34 weeks ago
Joined: 2003-09-20
Posts: 208
Points: 0

1st CSS Tableless Site - views appreciated

pipe = | = the thing that is sitting too close to "resume" because you forgot to put a space before it Wink

larmyia
Offline
Elder
London
Last seen: 12 years 1 week ago
London
Timezone: GMT+1
Joined: 2005-01-25
Posts: 1060
Points: 0

1st CSS Tableless Site - views appreciated

aha! well spotted! I did that just to see if anyone would notice Wink

hehe

thanks!