4 replies [Last post]
dewon
Offline
Regular
Japan/Finland
Last seen: 12 years 27 weeks ago
Japan/Finland
Timezone: GMT-2
Joined: 2005-01-01
Posts: 17
Points: 0

I just finished this site for my friend.
What do you think?
Guestbook does not work on FF, I know Oups

http://koti.mbnet.fi/dewon/kinpo/

Hugo
Hugo's picture
Offline
Moderator
London
Last seen: 6 years 40 weeks ago
London
Joined: 2004-06-06
Posts: 15668
Points: 2806

Can you look at this simple css-based site?

Nicely executed design, looks good ( is it inspired by the 'Kubrick' wp template ?)

Couple of small points I would knock the DTD down to 1.0 strict as the current usage of 1.1 is not really correct and you may want to consider some filtering of rules to accommodate IE5 interpretation of the box model ( if that sort of thing concerns you) also run it through the validator as it's failing on some minor points such as unescaped ampersands.
Other than small issues, it's an elegant fresh design.

Hugo.

Before you make your first post it is vital that you READ THE POSTING GUIDELINES!
----------------------------------------------------------------
Please post ALL your code - both CSS & HTML - in [code] tags
Please validate and ensure you have included a full Doctype before posting.
Why validate? Read Me

dewon
Offline
Regular
Japan/Finland
Last seen: 12 years 27 weeks ago
Japan/Finland
Timezone: GMT-2
Joined: 2005-01-01
Posts: 17
Points: 0

Can you look at this simple css-based site?

Hugo wrote:
Nicely executed design, looks good ( is it inspired by the 'Kubrick' wp template ?)

Thanks for your feedback Hugo!
No, I hadn't even heard about that Kubrick template before this.
By fast look at google, I suppose that it is a some kind of blog-template?

Quote:
Couple of small points I would knock the DTD down to 1.0 strict as the current usage of 1.1 is not really correct

Do you mean that I'm not using it propely or that it's not supported to use it yet?

Quote:
and you may want to consider some filtering of rules to accommodate IE5 interpretation of the box model ( if that sort of thing concerns you)

Yep, I should do it.

By the way, when you look at navi in IE, you can see that the boxes are "popping up". Nevertheless, this isn't working in Opera or Mozilla. First I tried with z-indexes, but they didn't do the wanted result neither. Can anyone say, how I can get that thing working?

Hugo
Hugo's picture
Offline
Moderator
London
Last seen: 6 years 40 weeks ago
London
Joined: 2004-06-06
Posts: 15668
Points: 2806

Can you look at this simple css-based site?

Using 1.1 you are required to serve up the page with the correct mime type of application/xhtml+xml through the header and the page must have the xml prolog as the very first line of the document which throws IE into 'Quirks Mode' . the only real benefit of using it is if you are intending on using other languages and the full extensibility of xml within the page. It is acceptable to serve up 1.0 as either text/html or application/xhtml+xml though.

Hm, see what you mean about the menu FF isn't picking up the 20px right margin on the .navi a:hover , not sure why at the moment, FF seems to be obeying some sort of width constraint but I can't see where .
On a side note it may be better to clear the #menu or give it some height rather than using the bottom margin to obtain spacing and I would have used lists for the .navi rather than divs, but these are minor points.

Hugo.

Before you make your first post it is vital that you READ THE POSTING GUIDELINES!
----------------------------------------------------------------
Please post ALL your code - both CSS & HTML - in [code] tags
Please validate and ensure you have included a full Doctype before posting.
Why validate? Read Me

technossomy
technossomy's picture
Offline
Enthusiast
Last seen: 1 week 6 days ago
Timezone: GMT+2
Joined: 2004-06-09
Posts: 260
Points: 8

Can you look at this simple css-based site?

Hi dewon

Just a few tidbits of my own that may help you:

- Your navi class has a hover style which removes the top border, which may have to do with your margining set to 0 for the top. Of course, it could be that this has been a deliberate design decision.

- In this same menu you may want to grey out the items which are set to the currently open page. Especially since you are using PHP anyway, this should be an easy trick.

The site has good liquidity and overall has a refreshing look. Tested in IE6, FF1 and Op7.5.

Hope this helps

Tech