3 replies [Last post]
hlj71
hlj71's picture
Offline
Regular
Denver, CO
Last seen: 12 years 23 weeks ago
Denver, CO
Timezone: GMT-6
Joined: 2009-08-04
Posts: 20
Points: 15

Hi! I have just completed my first CSS-laid out site and would love some feedback on the code. I'm sure my code is a little bloated, so please let me know how to trim it down. I am also totally open to any other suggestions. I am still tweaking the drop-down menu background graphics (the rounder corners are a bit jagged). The content on the page is just filler for now.

http://www.aahahealthypet.com/home_v1.html

Thank you!!

Harms

Tyssen
Tyssen's picture
Offline
Moderator
Brisbane
Last seen: 8 years 16 weeks ago
Brisbane
Timezone: GMT+10
Joined: 2004-05-01
Posts: 8201
Points: 1386

- The comment above the

- The comment above the doctype will put IE in quirks (broken box model) mode.
- Don't like the internal scrollbars in the right column boxes.
- There's a lot of image-based headings on the page whose content doesn't actually appear in the page which is bad for devices that can't actually see your page, ie, search engines; screenreaders. This is particularly bad in the dropdown menus because if people have javascript disabled, they won't be able to access any of those areas of content. There are ways you can have real text in your page's code but a different image on screen; do a search on 'image replacement'.

How to get help
Post a link. If you can't post a link, jsFiddle it.
My blog | My older articles | CSS Reference

hlj71
hlj71's picture
Offline
Regular
Denver, CO
Last seen: 12 years 23 weeks ago
Denver, CO
Timezone: GMT-6
Joined: 2009-08-04
Posts: 20
Points: 15

Updated Code

Hey Tyssen! Thanks for your tips. The comment above the doctype is there because this page will be a aspx page and I thought we had to have that in there for ASP. Though, I just started a C# class, I know very little about it so far. The internal scollbars in the right column boxes will only display if there is content in the box that is longer than the box will hold. I found the FIR technique. I hadn't heard of this before, so it was VERY helpful. I have applied the technique to the page.

Do you think the rest of my code is OK? Any other tips you have would be great!

Thank you!! :thumbsup:

Harms

Tyssen
Tyssen's picture
Offline
Moderator
Brisbane
Last seen: 8 years 16 weeks ago
Brisbane
Timezone: GMT+10
Joined: 2004-05-01
Posts: 8201
Points: 1386

hlj71 wrote:The comment

hlj71 wrote:

The comment above the doctype is there because this page will be a aspx page and I thought we had to have that in there for ASP.

I don't know about that but I do know you'll be making your work with CSS much harder if you leave it in.

How to get help
Post a link. If you can't post a link, jsFiddle it.
My blog | My older articles | CSS Reference