6 replies [Last post]
Josh Connerty
Josh Connerty's picture
Offline
Enthusiast
Wiltshire, England
Last seen: 11 years 40 weeks ago
Wiltshire, England
Joined: 2008-10-17
Posts: 268
Points: 23

Hey guys,

Thanks for reading and taking a look at the design.

I've come up with this design for a site of mine and I was just wondering if you CSS experts could take a look at it and see if I could better my css.

SITE IS HERE

TheBMRR
TheBMRR's picture
Offline
Enthusiast
Last seen: 13 years 32 weeks ago
Timezone: GMT-5
Joined: 2009-02-25
Posts: 60
Points: 0

The link to your style sheet

The link to your style sheet is not working, unless you wanted it to be black text on a plain white background Wink

Josh Connerty
Josh Connerty's picture
Offline
Enthusiast
Wiltshire, England
Last seen: 11 years 40 weeks ago
Wiltshire, England
Joined: 2008-10-17
Posts: 268
Points: 23

Ooops, I think I still have

Ooops,

I think I still have it linked for my local server Tongue

I'll change it now haha.

Thanks for looking though.

Kelon
Offline
Regular
UK
Last seen: 13 years 39 weeks ago
UK
Joined: 2008-12-22
Posts: 17
Points: 0

WOW. How big? Sorry, I'm

WOW. How big? Sorry, I'm just so taken aback.... I know you asked for comments on stylesheets, not design, but if you're going to say "Web design" in your title then I really really would reduce your masthead size by 50%. I know there is a big (sorry) trend for these deep mastheads, which personally I don't get because screens are going wide not deep... anyhow... a positive is: you've won the competition for who's got the biggest Wink All the best., meant to help, please read with a friendly (yeah ok, cheeky) grin... cos it's how it was written.

Ed Seedhouse
Ed Seedhouse's picture
Offline
Guru
Victoria British Columbia
Last seen: 1 year 42 weeks ago
Victoria British Columbia
Timezone: GMT-8
Joined: 2005-12-14
Posts: 3570
Points: 675

Why a transitional doctype

Why a transitional doctype declaration? What are you transitioning from?

Modern best practice is to use STRICT document types. It will alert you of more errors which, when cured, will make your site more robust across browsers. And it says you are a "pro". Transitional doctypes just scream "amateur".

Ed Seedhouse

Posting Guidelines

Watch out! I am carrying irony, sarcasm and satire, and know how to use them.

Tyssen
Tyssen's picture
Offline
Moderator
Brisbane
Last seen: 8 years 8 weeks ago
Brisbane
Timezone: GMT+10
Joined: 2004-05-01
Posts: 8201
Points: 1386

Yeah, the header's way too

Yeah, the header's way too big. Lots of other problems as I see it:

- The whole thing looks amateurish - helped along majorly by the use of Comic Sans.
- The blue background graphic doesn't tile properly.
- The green thing in the logo is off centre.
- The green borders around your login form look wrong and the whole form is way too prominent, pushing any worthwhile content further down the page. And why do you need to say "Design by...." on it? And no need to use a table to mark it up.
- Your heading tags are out of sequence, you've got a h2 before a h1.
- This:

Dummy Text

should be marked up with a heading tag.
- You don't need

  • to create borders between your nav elements; just use CSS borders.
    - font-family: Tahoma; is a fairly limited font stack to be declaring on the body. You should at least specify sans-serif with it.

    How to get help
    Post a link. If you can't post a link, jsFiddle it.
    My blog | My older articles | CSS Reference

    Josh Connerty
    Josh Connerty's picture
    Offline
    Enthusiast
    Wiltshire, England
    Last seen: 11 years 40 weeks ago
    Wiltshire, England
    Joined: 2008-10-17
    Posts: 268
    Points: 23

    @Ed right the only reason

    @Ed right the only reason for this is because I was using a PC that I haven't used for a while and it was either dreamweaver or notepad. And I couldn't be bothered to change the DTD. It wasn't permenant.

    Ok so the general feelings are start again haha.

    It was late and I didn't see how bad it was till the morning/afternoon after.

    Then I just thought I would see what you thought anyway. I'm going to go for a re-design. Laughing out loud

    Thanks for the ideas guys.

    By the way I took no offence I felt the same way haha Tongue.