9 replies [Last post]
sarah53
sarah53's picture
Offline
Regular
Last seen: 11 years 32 weeks ago
Joined: 2009-02-01
Posts: 20
Points: 0

Please have a look and let me know what you think:

artemosaic.com

I am still working on it, so in the moment just the main page has the ready stylesheet.

I checked it on IE6, where it works with a separated stylesheet, and IE7 and firefox. For some reason, IE 7 did not want to eat the CC so I was fixing it in a way to work with the original stylesheet.

I would like to know if there is any problems I can encounter with the way I made it or if any browser i did not check has any trouble with it.

It would be better if it adjusted to the size of the browser window but because of those IE7-problems I decided to leave it just like that.

Thanks for anyone that takes the time to comment!

Ed Seedhouse
Ed Seedhouse's picture
Offline
Guru
Victoria British Columbia
Last seen: 40 weeks 2 days ago
Victoria British Columbia
Timezone: GMT-8
Joined: 2005-12-14
Posts: 3570
Points: 675

As I understand things,

As I understand things, "Site Checks" is only for sites that are pretty well ready to go live. If you only have one page that doesn't seem to meet the criteria.

Other than that you should correct your html errors too.

Ed Seedhouse

Posting Guidelines

Watch out! I am carrying irony, sarcasm and satire, and know how to use them.

sarah53
sarah53's picture
Offline
Regular
Last seen: 11 years 32 weeks ago
Joined: 2009-02-01
Posts: 20
Points: 0

I am sorry if I was jumping to fast...

...but HTML Errors?

I validated and W3C says it's fine. But please let me know if there is something wrong.
Thanks
Sarah

Tony
Tony's picture
Offline
Moderator
Brisbane
Last seen: 2 weeks 3 days ago
Brisbane
Timezone: GMT+10
Joined: 2003-03-12
Posts: 5343
Points: 2964

Hi Sarah, Nice looking

Hi Sarah,
Nice looking site.
Here's a couple of things that could be fixed or improved.

    * You have an extra closing bracket at the end of your stylesheet.
    * A couple of the images are too large, try different compression settings or image formats such as jpeg.
Ed Seedhouse
Ed Seedhouse's picture
Offline
Guru
Victoria British Columbia
Last seen: 40 weeks 2 days ago
Victoria British Columbia
Timezone: GMT-8
Joined: 2005-12-14
Posts: 3570
Points: 675

sarah53 wrote:...but HTML

sarah53 wrote:

...but HTML Errors?

I validated and W3C says it's fine.

No it doesn't.

Ed Seedhouse

Posting Guidelines

Watch out! I am carrying irony, sarcasm and satire, and know how to use them.

Tyssen
Tyssen's picture
Offline
Moderator
Brisbane
Last seen: 5 years 50 weeks ago
Brisbane
Timezone: GMT+10
Joined: 2004-05-01
Posts: 8201
Points: 1386

You need to give #olho a

You need to give #olho a width to kill off the horizontal scrollbar. Your approach to using IE CCs for stylesheets is wrong - you don't need to repeat the whole stylesheet; just add to it the fixes required to correct IE's bugs.

How to get help
Post a link. If you can't post a link, jsFiddle it.
My blog | My older articles | CSS Reference

burlster
burlster's picture
Offline
Leader
Bournemouth
Last seen: 3 years 2 days ago
Bournemouth
Timezone: GMT+1
Joined: 2007-05-31
Posts: 693
Points: 45

Size 6 foot in a Size 10 shoe?

Oh, I like the site! Very nice!

Can I make a suggestion? If you added display: block to the links in the LIs that make up your buttons, they would span the whole LI, and then if you removed the padding for top and bottom from the LI and added them to the A instead, you would effectively end up with something that looked exactly the same but the whole area would be clickable. Instead of a link in a box, you would have a whole button with very few changes Smile

Cheers,

Johnny B

Have YOU said Hello yet?
The CSSCreator Hello Thread

sarah53
sarah53's picture
Offline
Regular
Last seen: 11 years 32 weeks ago
Joined: 2009-02-01
Posts: 20
Points: 0

[gasp]Caught me with my HTML-pants down...[/gasp]

...but I would be glad if it was the only thing that was slightly different from what I wanted.

First of all a very, very big THANK YOU! to all of you. Just by your comments I am already learning loads of stuff. I am the total learning by doing person, but unfortunately with this approach lots of things lie undiscovered until someone gives a hint.
For example that display:block thing. I am going to try that right now.

Another idea I had and wanted to try, but now I don't know if that works with all that position:absolute that glues things to the place: Is it possible to put all the stuff together in a div and let it float in the middle of the page?
Or is that a larger headache and should be tried another day, another page?

Greetings,
Sarah

Tyssen
Tyssen's picture
Offline
Moderator
Brisbane
Last seen: 5 years 50 weeks ago
Brisbane
Timezone: GMT+10
Joined: 2004-05-01
Posts: 8201
Points: 1386

Using position:absolute for

Using position:absolute for everything can cause a lot of unwanted problems if you're inexperienced and generally I wouldn't recommend using it for large blocks of content as they're removed from the flow of the page which means none of the content around a pos:abs element knows it's there.

How to get help
Post a link. If you can't post a link, jsFiddle it.
My blog | My older articles | CSS Reference

sarah53
sarah53's picture
Offline
Regular
Last seen: 11 years 32 weeks ago
Joined: 2009-02-01
Posts: 20
Points: 0

Absolutely right...

...I was fiddling a bit around with it but really that stuff sits where it is. Well, next time I know better.
Have still to get into positioning, I just start understanding it. For this page it will make more sense to leave it where it is, as it is my business page and though it has few daily visitors it is not very nice to confuse them with all of these building works.

The buttons are all in place with the help of display:block and I am very happy about them, they really make it all look much more pro. (well on the low level where I am still crawling around, a changing color on a button is a fine thing!)

For now, I will just add the new design to the missing pages and after that attack the next project.

About the IE7 and CC: I saw on several pages that there was a whole new stylesheet added and linked to the pages with a CC.
And it seems to work with IE6. (I hope) So for IE7 to get his feed of extra-measures I would have to add a CC to every single point I want to have changed and that would do the trick?