7 replies [Last post]
apa
apa's picture
Offline
newbie
Last seen: 12 years 13 weeks ago
Joined: 2008-11-18
Posts: 9
Points: 0

Hello All,
The site I've designed and made for the college I work at is ready to go live on Monday morning (the 12th of Jan) but before then I thought it might be good if you had a look over it for me and pass on any suggestions or ideas...

You can find it at: http://vle.asfc.ac.uk/newinternet/

On Monday morning it will be live at: http://www.asfc.ac.uk

Thanks in advance - I welcome all comments and criticisms Smile

Kind regards,
Adam

vin2785
Offline
Regular
West Yorkshire
Last seen: 11 years 16 weeks ago
West Yorkshire
Joined: 2008-12-12
Posts: 35
Points: 11

I like the design but the

I like the design but the html isn't valid and resizing the text via the a+ and a++ links is breaking up the layout...

CupidsToejam
CupidsToejam's picture
Offline
Guru
Florida
Last seen: 5 years 30 weeks ago
Florida
Timezone: GMT-4
Joined: 2008-08-15
Posts: 2637
Points: 1556

dont hate me, love me

1. Does not validate Smile

2. Your "text only" version is broken.

3. A++ breaks

4. Strange, but "adult" and "resources" menu items, fall behind the flash animation, but only when there is a transition.

5. Top leval nav behaves very bad! It should only activate when i roll over the top level menu items, not the menu children. Like when you roll the cursor under the menu, it activates.

6. Why use Media & Film? is there something wrong with the spacebar?

7. A better way of doing this,
<span class="headerlink"><a href="about/news/2008_12_01.php">
would be to add a class to the

8. Research divitis

9. I like the colors.

10. I'm not going to sift through your CSS, but i was searching for a line-height for the body, and came across this

.WhiteText{line-height: 14px;}

Looks like you are using line height, where you should be using margin, or padding.

11. You need more line-height for your body text. lines are too close together.

12. your XHTMl should be more symantec. I didnt see any heading tags anywhere like .

13. I feel like your headings should stand out more.

Thats all i have time for. Sorry if I pissed you off.

apa
apa's picture
Offline
newbie
Last seen: 12 years 13 weeks ago
Joined: 2008-11-18
Posts: 9
Points: 0

Hi CupidsToejam,Don't worry

Hi CupidsToejam,
Don't worry - you haven't pissed me off at all - I value your thoughts and criticisms!

Point 1 - I think the main validation issue is coming from the php code for the style switcher, I will have to see how I can fix that.

Point 2 - I agree, the text only version is a little lame at the moment, I am aiming to make that a proper feature at somepoint.

Point 3 - When you say the A++ breaks, how do you mean? I know it kind of knocks a little of the design out of whack but I thought the text itself resized ok...

Your points number 4 & 5:

4. Strange, but "adult" and "resources" menu items, fall behind the flash animation, but only when there is a transition.
5. Top leval nav behaves very bad! It should only activate when i roll over the top level menu items, not the menu children. Like when you roll the cursor under the menu, it activates.

This is an issue that is really bugging me and I am at a loss of how to fix them... anyone out there with any ideas??

Point 6 - I've used & between Media & Film as it's a section for the course of both Media and Film.

Point 7 - Thankyou very much for this suggestion - I will put it in action asap :thumbsup:

Point 8 - Yep, I do seem to have wrapped myself up in lots and lots of divs Sad I think this is somekind of bad habit I must have got into and will try and teach myself out of it for the next project I do!

Point 10 & 11 - Cheers for that advice, I'll implement it and see what happens

Point 12 - I agree, I should have built some heading tags into it... I think I will have to make those additions again asap.

Thanks again for all your advice (and thanks for the colour complement!), I appriciate the time you put into looking at it and feeding back for me Smile

Deuce
Deuce's picture
Offline
Guru
Somewhere, USA
Last seen: 3 years 38 weeks ago
Somewhere, USA
Timezone: GMT-5
Joined: 2005-11-20
Posts: 4424
Points: 1843

CupidsToejam wrote: 6. Why

CupidsToejam wrote:

6. Why use Media & Film? is there something wrong with the spacebar?

I think you're thinking of  

all » http://dictionary.reference.com/browse/all

Google isn't a bunch of guys reading and grading web sites, it's more like a bunch of monkeys sniffing food and putting the good bananas at the top. -Triumph

Deuce
Deuce's picture
Offline
Guru
Somewhere, USA
Last seen: 3 years 38 weeks ago
Somewhere, USA
Timezone: GMT-5
Joined: 2005-11-20
Posts: 4424
Points: 1843

apa wrote:Hi

apa wrote:

Hi CupidsToejam,

Point 3 - When you say the A++ breaks, how do you mean? I know it kind of knocks a little of the design out of whack but I thought the text itself resized ok...

Here is a screenshot from my mac set to A++

Also - http://validator.w3.org/check?verbose=1&uri=http%3A%2F%2Fvle.asfc.ac.uk%2Fnewinternet%2Findex.php%3F1%3D1%261%3D1

AttachmentSize
Picture 1.png 487.55 KB

all » http://dictionary.reference.com/browse/all

Google isn't a bunch of guys reading and grading web sites, it's more like a bunch of monkeys sniffing food and putting the good bananas at the top. -Triumph

CupidsToejam
CupidsToejam's picture
Offline
Guru
Florida
Last seen: 5 years 30 weeks ago
Florida
Timezone: GMT-4
Joined: 2008-08-15
Posts: 2637
Points: 1556

Deuce wrote:CupidsToejam

Deuce wrote:
CupidsToejam wrote:

6. Why use Media & Film? is there something wrong with the spacebar?

I think you're thinking of  

oh yeah, thats what I get for skimming the code :shrug:

Deuce
Deuce's picture
Offline
Guru
Somewhere, USA
Last seen: 3 years 38 weeks ago
Somewhere, USA
Timezone: GMT-5
Joined: 2005-11-20
Posts: 4424
Points: 1843

CupidsToejam wrote:Deuce

CupidsToejam wrote:
Deuce wrote:
CupidsToejam wrote:

6. Why use Media & Film? is there something wrong with the spacebar?

I think you're thinking of  

oh yeah, thats what I get for skimming the code :shrug:

It happens...

all » http://dictionary.reference.com/browse/all

Google isn't a bunch of guys reading and grading web sites, it's more like a bunch of monkeys sniffing food and putting the good bananas at the top. -Triumph