4 replies [Last post]
ironklad
Offline
newbie
Last seen: 14 years 14 weeks ago
Joined: 2008-10-15
Posts: 5
Points: 0

Hi,

This is a revamp of a site I made about a year and a half ago from individual html files, laid out in tables. Hard to update, and messy in some places!

So now I've got everything in a nice modular WordPress theme, and all pages validate XHTML 1.0 Strict. I just need to add in the gallery page, and I wanted to get some feedback on what I have so far. I tried to make my code as streamlined as possible, but I'll take suggestions.

BTW this is my client's portfolio, not mine.

http://chrisbiagi.com/testblog/

Thanks

Tyssen
Tyssen's picture
Offline
Moderator
Brisbane
Last seen: 8 years 15 weeks ago
Brisbane
Timezone: GMT+10
Joined: 2004-05-01
Posts: 8201
Points: 1386

Everything looks OK except

Everything looks OK except for the form; it looks really weird. Labels are too far away from the inputs. For a form like this, you're better to right-align the labels.

How to get help
Post a link. If you can't post a link, jsFiddle it.
My blog | My older articles | CSS Reference

ironklad
Offline
newbie
Last seen: 14 years 14 weeks ago
Joined: 2008-10-15
Posts: 5
Points: 0

Yeah, I see what you mean

Yeah, I see what you mean there. I was a little torn between left-align or right-align; I went with left-align mainly because I like the nice straight left edge. I may go with your suggestion..

I have one other question, though it's really a WordPress specific question. I'm targeting the class current_page_item in my CSS, to make the current page li display in white in the menu bar. However, if you view any of the sub sections of the News page, the word News is no longer highlighted. Try clicking on any of the links under 'Current News' in the sidebar to see what I mean.

From looking at the source, I can see that WordPress isn't assigning current_page_item to the News li when it displays a sub section, but I don't know how to fix this.

Thanks

Tyssen
Tyssen's picture
Offline
Moderator
Brisbane
Last seen: 8 years 15 weeks ago
Brisbane
Timezone: GMT+10
Joined: 2004-05-01
Posts: 8201
Points: 1386

Maybe you could use

Maybe you could use if(is_category) and if(is_single) to add the missing class to that nav item for the other pages.

How to get help
Post a link. If you can't post a link, jsFiddle it.
My blog | My older articles | CSS Reference

ironklad
Offline
newbie
Last seen: 14 years 14 weeks ago
Joined: 2008-10-15
Posts: 5
Points: 0

Thanks, I'll look into

Thanks, I'll look into those.

BTW, my menu list is generated by WP with the wp_list_pages tag. Would I be modifying this tag somehow, or replacing it entirely with some more complex PHP?