3 replies [Last post]
SidP7
Offline
Regular
Last seen: 12 years 34 weeks ago
Joined: 2008-06-19
Posts: 29
Points: 0

I've finally completed my fathers civil engineering consultancy site design and would love a critique / review from the public.

www.pendharkar.co.in

- Some of the fonts are fixed (i had to compromise to make the layout work)
- There will be a text-only version implemented at some point. For now, both the light and dark themes will hopefully suffice.
- The images aren't optimized fully but will be once the review process is completed.
- Navigation works via javascript, but all sections of the site are accessible without javascript. (only the theme switching isn't)

Thanks for taking the time to review my work. All constructive criticism is welcome. Thank you in advance,

Regards,

Siddharth

SidP7
Offline
Regular
Last seen: 12 years 34 weeks ago
Joined: 2008-06-19
Posts: 29
Points: 0

It seems there is a problem

It seems there is a problem the menu list and drop down menu when viewed with IE7 and FireFox 3.01 MAC OX. Since I have neither of these browsers installed and I've used up my Browsershots credits for the day I'm unable to check if the changes i've made have worked.

If the problem still exists, and someone out there know how to fix it please let me know. It's frustrating because i'm unable to make realtime changes and see what the result is.

I suspect the issue is with CSS Stylsheet DARK_MAINELEMENTS in the use of text-align:center to center the body and html, and the text-align:left for the wrapper text.

Looks like absolute positioning is the likely issue...

:shrug:

Hugo
Hugo's picture
Offline
Moderator
London
Last seen: 6 years 17 weeks ago
London
Joined: 2004-06-06
Posts: 15668
Points: 2806

Your not ready for prime

Your not ready for prime time yet , those menu items are way off in IE7 and FF 2 for Windows but seem to be fine in Safari 2 and FF 3.01 for Mac OSX .

This is one of those problems when you try and place elements to sit positioned absolutely in graphic layouts of this type, you have to fully grasp how 'absolute' works.

I haven't time to try and see where things are going awry but you must get yourself a decent browser testing environment, placing position:relative on the #wrapper will adjust the lower menu into position, the top is better but still out, also I'm afraid with these types of layouts any text size increase immediately breaks the layout, you should really try and avoid over use of graphical layouts in this way.

Before you make your first post it is vital that you READ THE POSTING GUIDELINES!
----------------------------------------------------------------
Please post ALL your code - both CSS & HTML - in [code] tags
Please validate and ensure you have included a full Doctype before posting.
Why validate? Read Me

SidP7
Offline
Regular
Last seen: 12 years 34 weeks ago
Joined: 2008-06-19
Posts: 29
Points: 0

Positioning problems have

Positioning problems have been fixed now.