4 replies [Last post]
rnordvik
Offline
newbie
Last seen: 13 years 51 weeks ago
Timezone: GMT-7
Joined: 2008-08-26
Posts: 6
Points: 0

Hi all,

I stumbled upon this site today, and joined immediately, as it looks like this is a fantastic resource, especially for a noob designer, like myself!

I have worked out the page design for a client's site, and would love to have some comments/critique regarding the underlying XHTML/CSS, prior to submitting the design to the client for approval.

I have validated the XHTML and CSS, and other than the transparent png fix, found in the ie6hacks.css file, everything validates fine, and looks correct in ie6, ie7, ff2&3 (Mac), ff2(Win), Safari 3(Mac).

Thanks in advance!
-Rob

http://financialfreedom.ibsmktg.com

Caposoft
Caposoft's picture
Offline
Enthusiast
Last seen: 7 years 35 weeks ago
Timezone: GMT+1
Joined: 2008-03-16
Posts: 330
Points: 118

I like it

I like it, the colors match, the site looks clean. It is probably a question of individual taste, but I like something that defines a border between content and the body. I would probably define it with a background. A border on the DIV would probably don't look too good.

2 critics: don't use images for text (NEXT button), and don't use fixed font size

purewebdesigner
purewebdesigner's picture
Offline
Enthusiast
Washington DC
Last seen: 3 years 45 weeks ago
Washington DC
Timezone: GMT-5
Joined: 2007-04-22
Posts: 234
Points: 95

I like your header and

I like your header and footer, the main content area could use something to help separate it from the page background. Maybe a background color to the website will help with this.

CSSExpression EngineHTMLWordpressCoffee

Personal Website: curtisscott.com
Follow Me on Twitter: twitter.com/curtisscott_com

rnordvik
Offline
newbie
Last seen: 13 years 51 weeks ago
Timezone: GMT-7
Joined: 2008-08-26
Posts: 6
Points: 0

Changed BG and Font Size

Thanks for the comments.

I have added a page background and a border, to separate the content and page. I also changed the font-size to use ems, rather than pixels, thereby adding font scalability in IE.

The 'NEXT' text in the NEXT button is a sticking point though. I am always very adamant about not using graphical text, but this is meant to be a graphical button, and does have accessible ALT text. I don't want this button look/size to change in different browsers or with different browser font settings. With all this in mind, is it still bad form to have this button be a graphic, rather than text with a graphic background?

Again, thanks for your suggestions. Please feel free to keep them coming.

-Rob

rnordvik
Offline
newbie
Last seen: 13 years 51 weeks ago
Timezone: GMT-7
Joined: 2008-08-26
Posts: 6
Points: 0

Added a page background

Thanks for the comments. I have added a page background and border to separate the content from the page. Please have another look and let me know what you think.

Thanks again,
-Rob