10 replies [Last post]
jckpalmer
Offline
Regular
UK
Last seen: 13 years 8 weeks ago
UK
Joined: 2008-07-10
Posts: 34
Points: 0

Hello,

Just finished the code for my ecommerce project.

Can you cast your professional eye's across these pages and give me your opinions, critique and any comments.

I would also like any tips / code pointers for making the code cross-compatible, accessable and correctly formatted for w3c.

I can't check it on the w3c site as it's not coded right in the PHP.

http://lunar.etopians.com

There's also a little bit in the "enteded tabs 2" divs that needs a bit of work if anyone can give me a quick solution to solve the width / spacing issue. Looks cramped up to the left.

Appreciate it, guys.

Thanks.

id="css"
#css {
background:too tired for this!
}

Tyssen
Tyssen's picture
Offline
Moderator
Brisbane
Last seen: 6 years 49 weeks ago
Brisbane
Timezone: GMT+10
Joined: 2004-05-01
Posts: 8201
Points: 1386

Your doctype's incorrect and

Your doctype's incorrect and you've got loads of HTML errors. To be able to validate your page, add this to your page:

<meta http-equiv="Content-Type" content="text/html; charset=utf-8">

How to get help
Post a link. If you can't post a link, jsFiddle it.
My blog | My older articles | CSS Reference

jckpalmer
Offline
Regular
UK
Last seen: 13 years 8 weeks ago
UK
Joined: 2008-07-10
Posts: 34
Points: 0

Tell me something I don't know.

Although I appreciate your efforts, I know the doctype is incorrect, If I was a php coder I would have amended that. But i'm not and I don't know how to add the line to the code to display it on every page.

I'll have a go at that now, but to be honest, I have already found that out by trying to use the w3c validator.

I wouldn't have had half the problems I've had if I could have validated the code at each stumbling block.

If there are any ways I could get advice / tips with the following I'd appreciate it:

Accessibility
X-compatibility (browser tests)
SEO
General organisation (repeated ID's or classes)

When looking at the code please bare in mind that the site has been designed to be resold. The only thing that would need changing for each new design would be the CSS page and thus common elements such as fonts, headers, margins and layouts would need to be all editable simply and quickly.

So grouping tags or ID/Classes together would be a good idea, but still need to seperate certain pages.

Hope you modz and groupies can help.

id="css"
#css {
background:too tired for this!
}

David Laakso
David Laakso's picture
Offline
Enthusiast
US
Last seen: 13 years 4 weeks ago
US
Joined: 2008-07-18
Posts: 265
Points: 0

It shows up on the screen in

It shows up on the screen in IE/6, IE/7, Mac Opera, Mac Firefox/3.0, and Mac Safari. It is in keeping with the vast majority of sites on the Web in that "mousetype" is in place, and that the fonts are frozen in the IE's. I already know the excuses for not setting user default, and not unlocking the fonts in IE, so no suggestions on how to do so are forthcomming from this end.

Among other things, the horizontal alleys are a little deeper in IE/6 and IE/7 than in compliant browsers. But since you can't correct the 52 markup validation errors, what's the point in doing anything other than "letting it go" as is?

BTW, correctable CSS error:

615 Parse error - Unrecognized */ #main_right { float:right; background-color:#FF0000; width:150px; height:50px; }

Tyssen
Tyssen's picture
Offline
Moderator
Brisbane
Last seen: 6 years 49 weeks ago
Brisbane
Timezone: GMT+10
Joined: 2004-05-01
Posts: 8201
Points: 1386

jckpalmer wrote:If I was a

jckpalmer wrote:

If I was a php coder I would have amended that.

Why do you need to be a PHP coder to change a doctype?

How to get help
Post a link. If you can't post a link, jsFiddle it.
My blog | My older articles | CSS Reference

SidP7
Offline
Regular
Last seen: 13 years 1 week ago
Joined: 2008-06-19
Posts: 29
Points: 0

Valid HTML and CSS help with

Valid HTML and CSS help with SEO, and that should be one of the first things that you should aim for after the actual design of the site. I'm not sure why you mean by PHP because the problem with your site is:

1) You're using a transitional DTD when you really should be aiming for a STRICT

2) You CSS error on line 655 :
Parse error - Unrecognized */ #main_right { float:right; background-color:#FF0000; width:150px; height:50px; }

The site overall looks unfinished to me. The navbar at the top only has two options which is strange given the amount of empty space you have. There is way too much negative space in the template as well. Think about creating borders around the main elements on the page to pull everything together as currently it looks like only 50% of the site is completed.

On the plus side. I like your color palette and logo. It's clean and professional. Work on the site by reading up some more on html and wc3 validation and you'll have a much better looking site. Good luck! Smile

jckpalmer
Offline
Regular
UK
Last seen: 13 years 8 weeks ago
UK
Joined: 2008-07-10
Posts: 34
Points: 0

Clarification...

lol.

Ok shall I explain the whole project?!

Content

This site is an eCommerce site, it has a fully functional backend admin system and can autonomously create and edit unlimited pages, members and products dynamically using LAMP, Perl, JS and Java.

It has little or no content at present because the owners have not had access to the site yet and the data on the site is "test data" allowing me the CSS coder to see the site and design and code the CSS accordingly.

Code Checking

Guys, I only want you to look at the CSS...!? Or I would have gone to a HTML/PHP forum. Do you really need instruction to view my CSS code? Do you really just use the w3c validators to offer your advice or are there any genuinely critical helpfull experts that are willing to look at my CSS and offer opinions on the way I've coded it?

HTML Transitional DTD

The line of code offered as way to test the CSS validity has been entered, I have run the validation test so thank you for that.

I found the right PHP file luckily and entered the Transitional DTD code at the top of the page. As you can now see, it should desplay on everypage.

w3c validator

There are now 1 error's which don't make sence to me as its a CSS parse error, but I can't see the problem? The commenting code is correct as far as I can see.

I guess as with most things like this I'm better off just doing the x-compatibility test's myself, tidying the code myself and looking for mistakes and effeciency myself.

Why have a CSS forum to help people with CSS when no-one wants to help lol.

lunar.etopians.com

Kind Regards for any responces and opinions.

Jckpalmer

id="css"
#css {
background:too tired for this!
}

Hugo
Hugo's picture
Offline
Moderator
London
Last seen: 6 years 36 weeks ago
London
Joined: 2004-06-06
Posts: 15668
Points: 2806

You have posted in 'Site

You have posted in 'Site Checks' not 'Css Checks' posting to site checks generally means one is requesting an overall critique on a site that means layout , design, coding etc.

Before you make your first post it is vital that you READ THE POSTING GUIDELINES!
----------------------------------------------------------------
Please post ALL your code - both CSS & HTML - in [code] tags
Please validate and ensure you have included a full Doctype before posting.
Why validate? Read Me

jckpalmer
Offline
Regular
UK
Last seen: 13 years 8 weeks ago
UK
Joined: 2008-07-10
Posts: 34
Points: 0

My apologies would you be so

My apologies would you be so kind to move it for me? Thanks.

id="css"
#css {
background:too tired for this!
}

Tyssen
Tyssen's picture
Offline
Moderator
Brisbane
Last seen: 6 years 49 weeks ago
Brisbane
Timezone: GMT+10
Joined: 2004-05-01
Posts: 8201
Points: 1386

jckpalmer wrote:Guys, I only

jckpalmer wrote:

Guys, I only want you to look at the CSS...!? Or I would have gone to a HTML/PHP forum.

Sorry, it doesn't work that way. There's no point looking at your CSS if you HTML is invalid. The forum rules and guidelines clearly state that your HTML must be valid before asking questions.

Good luck trying to find another 'CSS' forum where they won't ask you to fix your HTML problems first before offering solutions.

How to get help
Post a link. If you can't post a link, jsFiddle it.
My blog | My older articles | CSS Reference

isedeasy
Offline
Enthusiast
Bristol
Last seen: 9 years 11 weeks ago
Bristol
Timezone: GMT+1
Joined: 2008-02-09
Posts: 74
Points: 12

I am guessing its something

I am guessing that error is something to do with the currency settings as you are getting some freaky symbol which utf-8 does not like...

Also that meta tag needs to go inside your and not outside of the tags...

Mark-up first, Styling second Wink

"If a man is trying to hang himself from the tree in my yard but the knot keeps slipping and allowing him to fall before it kills him do you expect someone to go out and teach him to tie a better knot?" - Triumph