7 replies [Last post]
Pixelpyro
Offline
Regular
London, UK
Last seen: 15 years 33 weeks ago
London, UK
Joined: 2004-04-20
Posts: 41
Points: 0

Hi Guys,

Fnished my first XHTML CSS site and just waiting for the domain to transfer over before it goes live.

As it's my first one I thought I'd ask for people's opinions, thoughts and comments on the markup of my stylesheet - what should I do next time, good practices etc. It validates which is good but i am sure it needs work.

I am still very much learning and realise that I still have alot to learn but feedback at this stage would stop bad habits.

Here is the site,
http://eden.copious.co.uk/

here is the stylesheet
http://eden.copious.co.uk/eden.css

Thanks in advance.

thepineapplehead
thepineapplehead's picture
Offline
Guru
Last seen: 1 year 16 weeks ago
Timezone: GMT+1
Joined: 2004-06-30
Posts: 9668
Points: 801

Stylesheet assessment please

Looks very nice. There's a lot of stuff I don't understand. The only thing I could think is in several places you refer to it as #FFF and in others it is White. If I were you I'd stick to hex values throughout.

Verschwindende wrote:
  • CSS doesn't make pies

Pixelpyro
Offline
Regular
London, UK
Last seen: 15 years 33 weeks ago
London, UK
Joined: 2004-04-20
Posts: 41
Points: 0

Stylesheet assessment please

Far point - thanks

rmfred
rmfred's picture
Offline
Elder
Rock Springs, WY
Last seen: 1 year 9 weeks ago
Rock Springs, WY
Timezone: GMT-6
Joined: 2004-01-31
Posts: 1073
Points: 31

Stylesheet assessment please

Most excellent design... looks very professional

Pixelpyro
Offline
Regular
London, UK
Last seen: 15 years 33 weeks ago
London, UK
Joined: 2004-04-20
Posts: 41
Points: 0

Stylesheet assessment please

thank you rmfred

Hugo
Hugo's picture
Offline
Moderator
London
Last seen: 4 years 48 weeks ago
London
Joined: 2004-06-06
Posts: 15668
Points: 2806

Stylesheet assessment please

Hi Pixelpyro,

Looks good, well done; I'm confused by one thing the use of the box model hack, the first time it's used you specify the same width although there is a border width to concider; the second time there is no border or padding yet the width gains 20px; not sure how that will display in IE5+ ( on my other box) maybe not an issue?

Hugo.

Before you make your first post it is vital that you READ THE POSTING GUIDELINES!
----------------------------------------------------------------
Please post ALL your code - both CSS & HTML - in [code] tags
Please validate and ensure you have included a full Doctype before posting.
Why validate? Read Me

Pixelpyro
Offline
Regular
London, UK
Last seen: 15 years 33 weeks ago
London, UK
Joined: 2004-04-20
Posts: 41
Points: 0

Stylesheet assessment please

Hi Hugo - thanks for the feedback, I'll have to look into it see why I did that and indeed if it causes any issues in IE5

Did you get my email re musicalsleuth.com?

if not let me know

Cheers

Pyro

The Finch
Offline
Enthusiast
Cincinnati
Last seen: 15 years 18 weeks ago
Cincinnati
Timezone: GMT-5
Joined: 2004-08-01
Posts: 65
Points: 0

Stylesheet assessment please

It looks great in FF, N7, O7. However, check out how the page reacts if you increase text-sze from within IE6