5 replies [Last post]
gregoryagu
Offline
newbie
Last seen: 15 years 31 weeks ago
Timezone: GMT-5
Joined: 2007-07-01
Posts: 3
Points: 0

OK, so this is my first CSS driven web site. I have put it through the CSS checker, and the XHTML checker and they come out ok.

Any comments would be appreciated!

www.GregGum.com

Greg

thepineapplehead
thepineapplehead's picture
Offline
Moderator
Last seen: 41 weeks 1 day ago
Timezone: GMT+1
Joined: 2004-06-30
Posts: 9683
Points: 819

Move the CSS to an external

Move the CSS to an external file, get rid of the inline styling, and see if you can cut down on any of the divs.

Also get a H1 with your site title, and set this:

http://www.greggum.com/images/rrg_top1.gif

as it's background image.

The page also doesn't have a proper <title> Wink

Verschwindende wrote:
  • CSS doesn't make pies

gregoryagu
Offline
newbie
Last seen: 15 years 31 weeks ago
Timezone: GMT-5
Joined: 2007-07-01
Posts: 3
Points: 0

Thanks very much. I moved

Thanks very much.

I moved the CSS out to an external file, and am in progress with moving the inline styling. I didn't realize how much Visual Studio 2005 put in the inline styling.

However, I don't quite get what you mean about the H1. Do you mean instead of having a top Div that displays rrg_top1, do it with an H1 tag? I didn't realize that an H1 could have a background. I guess one would do that for improved search engine ranking, correct?

Greg

thepineapplehead
thepineapplehead's picture
Offline
Moderator
Last seen: 41 weeks 1 day ago
Timezone: GMT+1
Joined: 2004-06-30
Posts: 9683
Points: 819

Yes, yes, yes yes and

Yes, yes, yes yes and yes.

(I think that's enough Yeses!)

p.s.

Bad Request (Invalid Hostname)

Verschwindende wrote:
  • CSS doesn't make pies

dotancohen
Offline
Regular
Haifa
Last seen: 15 years 28 weeks ago
Haifa
Joined: 2007-05-26
Posts: 29
Points: 0

For one thing, the site does

For one thing, the site does not pass validation. Also, the search field flows over into the text, obscuring part of it.

. ' . ' . ' . ' . ' . ' . ' . ' . ' . ' . ' . Have a question: What is?

. ' . ' . ' . ' . ' . ' . ' . ' . ' . ' . ' . Like music? Song Lyrics

Deuce
Deuce's picture
Offline
Guru
Somewhere, USA
Last seen: 5 years 29 weeks ago
Somewhere, USA
Timezone: GMT-5
Joined: 2005-11-20
Posts: 4424
Points: 1843

I like the look, but does

I like the look, but does not pass w3c html or css validation

all ยป http://dictionary.reference.com/browse/all

Google isn't a bunch of guys reading and grading web sites, it's more like a bunch of monkeys sniffing food and putting the good bananas at the top. -Triumph