8 replies [Last post]
artcoder
artcoder's picture
Offline
Enthusiast
Last seen: 7 years 15 weeks ago
Timezone: GMT-8
Joined: 2005-07-27
Posts: 69
Points: 0

Just finished "Images from a Tea Garden". Let me know what you think in terms of both artistic and technical aspects. There are no tables and passes XHTML strict validation. I believe it is fairly cross-browser compatible. I have checked on Firefox, IE, and Safari, and Opera.

thepineapplehead
thepineapplehead's picture
Offline
Guru
Last seen: 8 weeks 8 hours ago
Joined: 2004-06-30
Posts: 9674
Points: 810

I think it needs slightly

I think it needs slightly more contrast, the links at the top could be a little hard to read.

You also need to ditch the default W3C valid buttons, they're ugly and don't match your site. I'd go for the cliche of the buttons in the footer Wink

Nice design though.

Verschwindende wrote:
  • CSS doesn't make pies

survinho
Offline
Regular
Last seen: 14 years 12 weeks ago
Joined: 2007-02-10
Posts: 14
Points: 0

Nice design. I found a few

Nice design. I found a few bugs in Internet Explorer lower then version 6 on a windows pc. As long as you're concerned here they are:

-in IE5.0 and IE5.5 your page isn't centered
-in IE5.5 your advertisements aren't showing
-in IE4 your site is totally messed up
-in IE3 (who cares) your menu, followed by your content is nicely shown along with some images

thepineapplehead
thepineapplehead's picture
Offline
Guru
Last seen: 8 weeks 8 hours ago
Joined: 2004-06-30
Posts: 9674
Points: 810

Also, your top menu breaks

Also, your top menu breaks with a simple text-resize Laughing out loud

Verschwindende wrote:
  • CSS doesn't make pies

artcoder
artcoder's picture
Offline
Enthusiast
Last seen: 7 years 15 weeks ago
Timezone: GMT-8
Joined: 2005-07-27
Posts: 69
Points: 0

survinho, how were you able

survinho, how were you able to test on all those IE's? Did you use a service, or did you hack IE on your machine so that they can run side-by-side?

artcoder
artcoder's picture
Offline
Enthusiast
Last seen: 7 years 15 weeks ago
Timezone: GMT-8
Joined: 2005-07-27
Posts: 69
Points: 0

thepineapplehead wrote:Also,

thepineapplehead wrote:
Also, your top menu breaks with a simple text-resize Laughing out loud

What browser were you seeing this in? I tried changing the text-size in IE7 and Firefox 2.0 and the functionality of the menu still worked. Although at larger text size the menu spills out into the masthead. I did find a broken link in one of my menu though.

Hugo
Hugo's picture
Offline
Moderator
London
Last seen: 6 years 18 weeks ago
London
Joined: 2004-06-06
Posts: 15668
Points: 2806

artcoder wrote:survinho, how

artcoder wrote:
survinho, how were you able to test on all those IE's? Did you use a service, or did you hack IE on your machine so that they can run side-by-side?

More importantly why do you bother survinho? IE3 are you serious!!, browsers 4 and older are not ever to be mentioned and they most certainly should never be shown any css whatsoever :mad:

Before you make your first post it is vital that you READ THE POSTING GUIDELINES!
----------------------------------------------------------------
Please post ALL your code - both CSS & HTML - in [code] tags
Please validate and ensure you have included a full Doctype before posting.
Why validate? Read Me

artcoder
artcoder's picture
Offline
Enthusiast
Last seen: 7 years 15 weeks ago
Timezone: GMT-8
Joined: 2005-07-27
Posts: 69
Points: 0

Changes made

Re: Images from a Tea Garden

Okay, I have changed the menu link color so that it has better constrast. Not sure if it is any better. I always have a difficult time picking colors.

I also moved the nav menu below the banner. I think it is better there than at top.

thepineapplehead
thepineapplehead's picture
Offline
Guru
Last seen: 8 weeks 8 hours ago
Joined: 2004-06-30
Posts: 9674
Points: 810

ul#navmenu li a, ul#navmenu

ul#navmenu li a, ul#navmenu li a:visited {
width: 92px;
color: #993300; /* c30 */
display: block;
line-height: 19px;
background-image:url(images/tab_off.jpg);
background-repeat:no-repeat;
text-decoration: none;
text-align: center;
background-color:#006633; <--- CHANGE THIS!
font-weight: bold;
font-size:12px;
}

Before your images for the nav items load, you have a horrible case of deep red text on a dark green background Tongue

Verschwindende wrote:
  • CSS doesn't make pies