9 replies [Last post]
FernE97
FernE97's picture
Offline
Enthusiast
Dublin, CA
Last seen: 37 weeks 5 days ago
Dublin, CA
Timezone: GMT-8
Joined: 2007-01-10
Posts: 176
Points: 44

I just came up with a basic portfolio site to get it on the web. First time I've laid out a page with css. Is the code alright, I'm sure there is probably some extra stuff in there that I don't need. Thanks for any feedback.

My Site
css code

FernE97
FernE97's picture
Offline
Enthusiast
Dublin, CA
Last seen: 37 weeks 5 days ago
Dublin, CA
Timezone: GMT-8
Joined: 2007-01-10
Posts: 176
Points: 44

also is there a better way

also is there a better way to line up the links? because right now they get activated even if you are not on the word because of the 40px padding to the right.

thepineapplehead
thepineapplehead's picture
Offline
Guru
Last seen: 1 year 13 weeks ago
Timezone: GMT+1
Joined: 2004-06-30
Posts: 9668
Points: 801

I'd move your logo image up

I'd move your logo image up so it's adjacent to the logo text, it's pushing too much of your content below the fold.

You're also suffering major classitis -

Break! Website::..

P CLASS="H1"??

It's a header. Use a heading tag Laughing out loud

This article may help:

www.csscreator.com/divitis

Verschwindende wrote:
  • CSS doesn't make pies

technossomy
technossomy's picture
Offline
Enthusiast
Last seen: 5 years 10 weeks ago
Timezone: GMT+1
Joined: 2004-06-09
Posts: 260
Points: 8

Good point

In general the use of [br /] is usually indicative of design problems.
Any reason why you have chosen to place the content on the right hand side of the viewport?

FernE97
FernE97's picture
Offline
Enthusiast
Dublin, CA
Last seen: 37 weeks 5 days ago
Dublin, CA
Timezone: GMT-8
Joined: 2007-01-10
Posts: 176
Points: 44

Thanks for the article. I

Thanks for the article. I tried to fix most of the stuff I think you were talking about but how do I get the spacing correct using the heading tags? I just want a single line break not a paragraph break. Is this any better?

My site css

FernE97
FernE97's picture
Offline
Enthusiast
Dublin, CA
Last seen: 37 weeks 5 days ago
Dublin, CA
Timezone: GMT-8
Joined: 2007-01-10
Posts: 176
Points: 44

Technossomy what content are

Technossomy what content are you talking about? most of it is aligned to the left

ClevaTreva
ClevaTreva's picture
Offline
Guru
A hilly place, UK
Last seen: 1 year 2 weeks ago
A hilly place, UK
Joined: 2004-02-05
Posts: 2902
Points: 0

Use Margins

If you want to space things further apart, use margins. I tend to specify these in ems when applying them to text, becuase they will be related to the text size.

You can specify them like this margin:1em 0em 1em 0em or margin:1em 0em, both are the same

The values in the four spell TRouBLe (Top Right Bottom Left) and in the pair are TB and RL

FernE97
FernE97's picture
Offline
Enthusiast
Dublin, CA
Last seen: 37 weeks 5 days ago
Dublin, CA
Timezone: GMT-8
Joined: 2007-01-10
Posts: 176
Points: 44

Cool thanks for the margins

Cool thanks for the margins advice. I think everything is cleaned up now but if anyone sees anything I should fix or do a better way let me know.

http://www.ejfernandez.com
css

thepineapplehead
thepineapplehead's picture
Offline
Guru
Last seen: 1 year 13 weeks ago
Timezone: GMT+1
Joined: 2004-06-30
Posts: 9668
Points: 801

I still by my earlier

I still by my earlier judgement about your logo:

thepineapplehead wrote:
I'd move your logo image up so it's adjacent to the logo text, it's pushing too much of your content below the fold.

Much better use of HTML elements though Smile

I'd also consider turning the big pictures into a link to the relevant website, make it easier to click to get to the site Laughing out loud

Verschwindende wrote:
  • CSS doesn't make pies

FernE97
FernE97's picture
Offline
Enthusiast
Dublin, CA
Last seen: 37 weeks 5 days ago
Dublin, CA
Timezone: GMT-8
Joined: 2007-01-10
Posts: 176
Points: 44

Alright I did your

Alright I did your suggestions and I think it works out better thanks.

http://www.ejfernandez.com