4 replies [Last post]
SethMace
Offline
Regular
Liverpool, England
Last seen: 11 years 27 weeks ago
Liverpool, England
Joined: 2006-12-25
Posts: 25
Points: 0

Have recently done this for a friend (thx Wolfcry for that clear:both tip;P) but would appreciate feedback on my coding style. Well, i aint a coder at heart, (i just like trying to create pretty looking things in photoshop;P) but i am banal enough to try and make the code neat & tidy:E Anyway, thanks in advance for any comments and try not to slaughter me too much:P

http://ccgi.sethmace.plus.com/ken/

p.s. Intending to make the top banner into flash with a small animated BIO on the artist there, is flash still resented by many web designers?

thepineapplehead
thepineapplehead's picture
Offline
Guru
Last seen: 1 year 16 weeks ago
Timezone: GMT+1
Joined: 2004-06-30
Posts: 9668
Points: 801

I'm not digging the way

I'm not digging the way you've laid out the links.

THey could do with a bigger line-height set so they sit at the middle of their container, and I'd prefer something like a rigth border on the elements to separate them as opposed to the hyphen symbol.

Verschwindende wrote:
  • CSS doesn't make pies

SethMace
Offline
Regular
Liverpool, England
Last seen: 11 years 27 weeks ago
Liverpool, England
Joined: 2006-12-25
Posts: 25
Points: 0

thepineapplehead wrote:I'd

thepineapplehead wrote:
I'd prefer something like a rigth border on the elements to separate them as opposed to the hyphen symbol.

Not sure what you mean by that?

Thx for the reply though, ill see what i can do about the links!

thepineapplehead
thepineapplehead's picture
Offline
Guru
Last seen: 1 year 16 weeks ago
Timezone: GMT+1
Joined: 2004-06-30
Posts: 9668
Points: 801

You see your links are

You see your links are separated by the - symbol?

It looks messy and unproffesional. A right border on the links would look better, like this:

link 1 | link 2 | link 3 | link 4 |

Verschwindende wrote:
  • CSS doesn't make pies

SethMace
Offline
Regular
Liverpool, England
Last seen: 11 years 27 weeks ago
Liverpool, England
Joined: 2006-12-25
Posts: 25
Points: 0

Ahh right, gottcha, thanks,

Ahh right, gottcha, thanks, will change that now:) That was just a personal preferrence of mine, never knew it was a noob sign!:E