3 replies [Last post]
Alienfeet
Alienfeet's picture
Offline
Regular
Last seen: 11 years 13 weeks ago
Timezone: GMT+1
Joined: 2006-05-24
Posts: 25
Points: 2

Hi there,

Comments and criticisms welcome on my latest CSS site. Be as tough as you like: usability, design, look and feel, errors etc.

http://www.marksmanproof.co.uk/websites/junairgroup

Thanks a lot

Hugo
Hugo's picture
Offline
Moderator
London
Last seen: 7 years 3 weeks ago
London
Joined: 2004-06-06
Posts: 15668
Points: 2806

Good Job!

Very nice, like the look a lot, good colour scheme and layout.

Only some immediate points that spring to mind, if you view with images disabled there are a few problems you ought to take care of:

1. viewing the #mainnav you have white text on a white background if the image you have placed on the #mainnav is removed so you should really declare a background to that image, background:#000 url(assets/navback.jpg) no-repeat;
and use shorthand notation loosing the background-repeat property.

2. Similar type problem with the right hand image links as you are left with nothing in their place. You have hidden the text using display:none but it would be better to shift the text off the screen so that screen readers can still see it; better still maybe move the image on the anchor to the span and position the span absolute so that it masks over the top of the text that way if image is disabled text will show through.

3. Should the right column text 'Our Brands' not be a heading tag rather than a paragraph one?
In fact you seem to have a lack of headings in the page instead what look as though they should actually be headings

case studies


Welcome to Junair

If you feel the need to call that class name leftcolheading is not that what it should be? I would review that and your use of spans in general to style sections and see wether you can't change them to headings

Hugo.

Before you make your first post it is vital that you READ THE POSTING GUIDELINES!
----------------------------------------------------------------
Please post ALL your code - both CSS & HTML - in [code] tags
Please validate and ensure you have included a full Doctype before posting.
Why validate? Read Me

Alienfeet
Alienfeet's picture
Offline
Regular
Last seen: 11 years 13 weeks ago
Timezone: GMT+1
Joined: 2006-05-24
Posts: 25
Points: 2

Thanks Hugo

Thanks for the comments.

Point 1. and 2. yes I agree, good point.

Point 3. I used classes in these as I wanted to keep the tag free for the title to each page (in blue below it) for search engine reasons. Unless you know of another way I could have done it?

Cheers Hugo, comment greatly appreciated.

Hugo
Hugo's picture
Offline
Moderator
London
Last seen: 7 years 3 weeks ago
London
Joined: 2004-06-06
Posts: 15668
Points: 2806

Have to admit I missed the

Have to admit I missed the h1 but the point of the heading tags is that it is a group of six levels they are meant for structuring a document running top to bottom large to small and they all play a part in describing a documents layout you don't have to use all of them. The h1 is of primary importance for search engines but the others play there part as well.

If you view the page without any styles you will better see the importance of them.

Hugo.

Before you make your first post it is vital that you READ THE POSTING GUIDELINES!
----------------------------------------------------------------
Please post ALL your code - both CSS & HTML - in [code] tags
Please validate and ensure you have included a full Doctype before posting.
Why validate? Read Me