15 replies [Last post]
ro88o
ro88o's picture
Offline
Enthusiast
Manchester, UK
Last seen: 13 years 36 weeks ago
Manchester, UK
Joined: 2005-06-29
Posts: 202
Points: 0

My sites been live for a bit now but I've been touching up on a few things recently (namely the forms and text) so I thought I'd get people's opinions and criticisms while I'm at it so I can get everything done at once.

URL: http://www.exyt-web.com

So fire away Laughing out loud Thanks in advance for any input.

www.nubornis.com
Web Development and E-commerce Solutions.

Hugo
Hugo's picture
Offline
Moderator
London
Last seen: 7 years 2 weeks ago
London
Joined: 2004-06-06
Posts: 15668
Points: 2806

Constructive criticisms for www.exyt-web.com please =)

Oops didn't check for errors Smile
mis-typed entity
&copy should be ©

perhaps focus for the tabbed through links and form inputs

Change the header image to a background rather than foreground and use an image replacement technique to hide some nice h1/h2 heading text. In fact the biggest error on the main page is that you have not used any heading tags at all!

I prefer the text sized up one notch in FF, looks better and is slightly more readable.

Contact page: if you claim accessibility then you must really look at your form, you should be using the fieldset tag and label tags on your inputs.

Good clean design!

Hugo.

Before you make your first post it is vital that you READ THE POSTING GUIDELINES!
----------------------------------------------------------------
Please post ALL your code - both CSS & HTML - in [code] tags
Please validate and ensure you have included a full Doctype before posting.
Why validate? Read Me

ro88o
ro88o's picture
Offline
Enthusiast
Manchester, UK
Last seen: 13 years 36 weeks ago
Manchester, UK
Joined: 2005-06-29
Posts: 202
Points: 0

Constructive criticisms for www.exyt-web.com please =)

Quote:
&copy should be ©

I've noticed that myself, when I change it, save and upload (through my dreamweaver) it never seems to change it on the site - I had the same problem with an ampersand on a site I made. Guess I'll have to try some other ways of uploading and see if that fixes the problem :?

Thanks for the rest of the tips, I'll look into them Smile

Meanwhile, any other input is welcomed.

www.nubornis.com
Web Development and E-commerce Solutions.

ro88o
ro88o's picture
Offline
Enthusiast
Manchester, UK
Last seen: 13 years 36 weeks ago
Manchester, UK
Joined: 2005-06-29
Posts: 202
Points: 0

Constructive criticisms for www.exyt-web.com please =)

Right, everything outlined below I've fixed (see http://www.exyt-web.com/index.html and http://www.exyt-web.com/comments.html).

Anything else that people would like to add while I'm still updating before I go ahead and change the rest of the pages ?

I'm assuming my image replacement technique is working and can be seen by screenreaders by the way although I don't really know how I could check this (I used the Leon Dwyer revised version of the FIR technique).

Thanks for any input, Tom

www.nubornis.com
Web Development and E-commerce Solutions.

Hugo
Hugo's picture
Offline
Moderator
London
Last seen: 7 years 2 weeks ago
London
Joined: 2004-06-06
Posts: 15668
Points: 2806

Constructive criticisms for www.exyt-web.com please =)

Personally I prefer that if images are disabled one gets the text heading in it's place using the image placed as an absolute positioned background overlaying the h1 and that the h1 is an absolute url reference to the site.

Hugo.

Before you make your first post it is vital that you READ THE POSTING GUIDELINES!
----------------------------------------------------------------
Please post ALL your code - both CSS & HTML - in [code] tags
Please validate and ensure you have included a full Doctype before posting.
Why validate? Read Me

ro88o
ro88o's picture
Offline
Enthusiast
Manchester, UK
Last seen: 13 years 36 weeks ago
Manchester, UK
Joined: 2005-06-29
Posts: 202
Points: 0

Constructive criticisms for www.exyt-web.com please =)

I don't quite understand what you mean, do you have a link to a site with information on that method please ?

www.nubornis.com
Web Development and E-commerce Solutions.

Hugo
Hugo's picture
Offline
Moderator
London
Last seen: 7 years 2 weeks ago
London
Joined: 2004-06-06
Posts: 15668
Points: 2806

Constructive criticisms for www.exyt-web.com please =)

http://wellstyled.com/css-replace-text-by-image.html

Main drawback is the use of an empty element to hold the image.

There are other methods that work on padding and overflow techniques to avoid the use of a un semantic empty element in the markup.

Hugo.

Before you make your first post it is vital that you READ THE POSTING GUIDELINES!
----------------------------------------------------------------
Please post ALL your code - both CSS & HTML - in [code] tags
Please validate and ensure you have included a full Doctype before posting.
Why validate? Read Me

ro88o
ro88o's picture
Offline
Enthusiast
Manchester, UK
Last seen: 13 years 36 weeks ago
Manchester, UK
Joined: 2005-06-29
Posts: 202
Points: 0

Constructive criticisms for www.exyt-web.com please =)

Fixed. Thanks for the link Laughing out loud

www.nubornis.com
Web Development and E-commerce Solutions.

Deuce
Deuce's picture
Offline
Guru
Somewhere, USA
Last seen: 4 years 28 weeks ago
Somewhere, USA
Timezone: GMT-5
Joined: 2005-11-20
Posts: 4424
Points: 1843

Constructive criticisms for www.exyt-web.com please =)

<div id="logo">
    <h1 id="pagetitle">Exyt Web Design - At The Cutting Edge.<span></span></h1>
  </div

what's the point of the <span></span> ?

you're using XHTML 1.0 Transitional but havn't closed your img tags

and again &copy needs to be &copy;

all » http://dictionary.reference.com/browse/all

Google isn't a bunch of guys reading and grading web sites, it's more like a bunch of monkeys sniffing food and putting the good bananas at the top. -Triumph

ro88o
ro88o's picture
Offline
Enthusiast
Manchester, UK
Last seen: 13 years 36 weeks ago
Manchester, UK
Joined: 2005-06-29
Posts: 202
Points: 0

Constructive criticisms for www.exyt-web.com please =)

The two span tags are there because the tutorial given above needs them to be there. Click the link to see why.

Which image tags have I not closed ? As far as I can see they all are and the page validates.

Which page are you viewing when you get the &copy problem ? On my browser it's coming up as &copy; in the index.html source and it validates.

www.nubornis.com
Web Development and E-commerce Solutions.

Deuce
Deuce's picture
Offline
Guru
Somewhere, USA
Last seen: 4 years 28 weeks ago
Somewhere, USA
Timezone: GMT-5
Joined: 2005-11-20
Posts: 4424
Points: 1843

Constructive criticisms for www.exyt-web.com please =)

ro88o wrote:

Which page are you viewing when you get the &copy problem ? On my browser it's coming up as &copy; in the index.html source and it validates.

http://www.exyt-web.com/whatWeOffer.html
http://www.exyt-web.com/standards.html
http://www.exyt-web.com/pricing.html
http://www.exyt-web.com/port_Past.html (&copy and img tag not closed)
http://www.exyt-web.com/port_Dev.html (&copy and img tag not closed)
http://www.exyt-web.com/contact.html

other error i noticed.

http://www.exyt-web.com/comments.html (<textarea> attribute "rows" lacks value)

all » http://dictionary.reference.com/browse/all

Google isn't a bunch of guys reading and grading web sites, it's more like a bunch of monkeys sniffing food and putting the good bananas at the top. -Triumph

Deuce
Deuce's picture
Offline
Guru
Somewhere, USA
Last seen: 4 years 28 weeks ago
Somewhere, USA
Timezone: GMT-5
Joined: 2005-11-20
Posts: 4424
Points: 1843

Constructive criticisms for www.exyt-web.com please =)

ro88o wrote:
The two span tags are there because the tutorial given above needs them to be there.

Have you tried removing the <span></span> and doing this instead.

#pagetitle {
    margin: 0;
	padding: 0;
    position: relative;
    width: 750px;
	height: 200px;
    margin: 0;
	padding: 0;
	overflow: hidden;
    background: url("logo.gif") top left no-repeat;
    display: block;
}

and then just drop the

#pagetitle span {
    display: block;
    position: absolute; 
	left: 0; 
	top: 0; 
	z-index: 1;
    width: 750px; 
	height: 200px;
    margin: 0; 
	padding: 0;
    background: url("logo.gif") top left no-repeat;
}

all together and see if that works?

all » http://dictionary.reference.com/browse/all

Google isn't a bunch of guys reading and grading web sites, it's more like a bunch of monkeys sniffing food and putting the good bananas at the top. -Triumph

ro88o
ro88o's picture
Offline
Enthusiast
Manchester, UK
Last seen: 13 years 36 weeks ago
Manchester, UK
Joined: 2005-06-29
Posts: 202
Points: 0

Constructive criticisms for www.exyt-web.com please =)

Deuce wrote:
http://www.exyt-web.com/port_Past.html (&copy and img tag not closed)
http://www.exyt-web.com/port_Dev.html (&copy and img tag not closed)

Yep still working on those, I'll update them soon.

Quote:
<textarea> attribute "rows" lacks value

I made the rows and cols attributes set to "" because I wanted to specify the size in pixels in the CSS.

As for your last post, no that would not work - that would make the heading text appear in the div. I'm not sure you understand what is trying to be done there, I'm using an image replacement technique - more specifically one that if a browser has images switched off a heading will be displayed instead.

www.nubornis.com
Web Development and E-commerce Solutions.

Hugo
Hugo's picture
Offline
Moderator
London
Last seen: 7 years 2 weeks ago
London
Joined: 2004-06-06
Posts: 15668
Points: 2806

Constructive criticisms for www.exyt-web.com please =)

Deuce this is a variation on the Farhner image replacement technique , a common CSS technique for images in headers replacing the heading text it may be worth studying the technique or one of the many variations.

Hugo.

Before you make your first post it is vital that you READ THE POSTING GUIDELINES!
----------------------------------------------------------------
Please post ALL your code - both CSS & HTML - in [code] tags
Please validate and ensure you have included a full Doctype before posting.
Why validate? Read Me

Deuce
Deuce's picture
Offline
Guru
Somewhere, USA
Last seen: 4 years 28 weeks ago
Somewhere, USA
Timezone: GMT-5
Joined: 2005-11-20
Posts: 4424
Points: 1843

Constructive criticisms for www.exyt-web.com please =)

ya, it helped me understand better when i went through and actually READ the entire thread, versus just scanning it.

Smile

all » http://dictionary.reference.com/browse/all

Google isn't a bunch of guys reading and grading web sites, it's more like a bunch of monkeys sniffing food and putting the good bananas at the top. -Triumph

technossomy
technossomy's picture
Offline
Enthusiast
Last seen: 16 weeks 3 days ago
Timezone: GMT+2
Joined: 2004-06-09
Posts: 260
Points: 8

Constructive criticisms for www.exyt-web.com please =)

Just had a quick glance at your site. I believe it is created for one font size only. For accessibility purposes you may want to look into methods of increasing/decreasing font sizes. Furthermore, I do not quite comprehend the need for titleText. Can't you put the associated styling in boxTitle instead? In boxTitle you could increase the padding at the top and bottom by a pixel or 3 to make the box titles more spacious.

Hope this helps

tech