8 replies [Last post]
DisinfectedBarfbag
DisinfectedBarfbag's picture
Offline
Enthusiast
Kent, UK
Last seen: 1 year 33 weeks ago
Kent, UK
Timezone: GMT+1
Joined: 2005-08-06
Posts: 411
Points: 1

Hi again,

I have added 8 more pages to my site with the entries from the old guestbook I used to use entered into tables.

I think it's all ok but can you see if you can spot any obvious errors :?:
http://www.about-gravesend.co.uk/oldguestbook1.php

Chris..S
Chris..S's picture
Offline
Moderator
Last seen: 9 years 11 weeks ago
Timezone: GMT+1
Joined: 2005-02-22
Posts: 6078
Points: 173

Please can you check these pages

It looks fine to me. I can't say I am too keen on the appearance of your next and previous page buttons, but there doesn't appear to be anything remiss with the HTML/CSS. You could add <thead>* and <tbody> tags, however they aren't really necessary in this instance.

<thead> allows you to group rows together. The browser should include <thead> content above other rows of the table on any page on which the table is printed. <thead> and <tbody> give you additional containers on which to use styles which target fragments of the table.

DisinfectedBarfbag
DisinfectedBarfbag's picture
Offline
Enthusiast
Kent, UK
Last seen: 1 year 33 weeks ago
Kent, UK
Timezone: GMT+1
Joined: 2005-08-06
Posts: 411
Points: 1

Please can you check these pages

Chris..S wrote:
It looks fine to me. I can't say I am too keen on the appearance of your next and previous page buttons
In what way, what would you suggest as a replacement :?:

Quote:
<thead> allows you to group rows together. The browser should include <thead> content above other rows of the table on any page on which the table is printed. <thead> and <tbody> give you additional containers on which to use styles which target fragments of the table.
I'll have a look and see what I can find about those tags. Thanks Chris

thepineapplehead
thepineapplehead's picture
Offline
Guru
Last seen: 4 days 17 hours ago
Joined: 2004-06-30
Posts: 9679
Points: 815

Please can you check these pages

I think it's the fact that the text is blue (default color) and doesn't fit in with the site, and the thick black border looks out of place.

Maybe styling it to look like the links on the left?

Verschwindende wrote:
  • CSS doesn't make pies

DisinfectedBarfbag
DisinfectedBarfbag's picture
Offline
Enthusiast
Kent, UK
Last seen: 1 year 33 weeks ago
Kent, UK
Timezone: GMT+1
Joined: 2005-08-06
Posts: 411
Points: 1

Please can you check these pages

Good point, have just updated the css, it now matches the pages better. The only problem I have is that I can't get the a:active to show the button without a small 'tab' on the left and right of it. If you look and click on a button you'll see what I mean.

Chris..S
Chris..S's picture
Offline
Moderator
Last seen: 9 years 11 weeks ago
Timezone: GMT+1
Joined: 2005-02-22
Posts: 6078
Points: 173

Please can you check these pages

TPH pretty well summed up what I thought. The new look is much better Smile

For the buttons, isn't that "tab" the 5px of padding on the div that contains the link. You could make the link display:block and put the borders on the link (and alter the borders on :active to make it look like the button is being pressed)

DisinfectedBarfbag
DisinfectedBarfbag's picture
Offline
Enthusiast
Kent, UK
Last seen: 1 year 33 weeks ago
Kent, UK
Timezone: GMT+1
Joined: 2005-08-06
Posts: 411
Points: 1

Please can you check these pages

Thanks guys, I have just done a bit of re-working again. I think this is what you meant. Smile

thepineapplehead
thepineapplehead's picture
Offline
Guru
Last seen: 4 days 17 hours ago
Joined: 2004-06-30
Posts: 9679
Points: 815

Please can you check these pages

Excellent, they look just like buttons now. Good job Laughing out loud

Just to nitpick, I'd probably give the buttons at the top a bigger bottom margin - they squash up against the "old guestbook entries" heading a bit much.

Verschwindende wrote:
  • CSS doesn't make pies

DisinfectedBarfbag
DisinfectedBarfbag's picture
Offline
Enthusiast
Kent, UK
Last seen: 1 year 33 weeks ago
Kent, UK
Timezone: GMT+1
Joined: 2005-08-06
Posts: 411
Points: 1

Please can you check these pages

Ok, I added a few more px that looks better now. And if you want to pick my nits, feel free. Wink