10 replies [Last post]
camel80
Offline
newbie
Last seen: 14 years 32 weeks ago
Joined: 2006-03-15
Posts: 8
Points: 0

Hi,

I have just finished my first css website and wondered if anyone could give me some pointers on code/design/etc...

Website

I adapted the navigation menu from listomatic and not too sure of the internal ids (e.g. navlist, subnavlist etc...). These bring up validation errors saying the elements have already been defined. However Dreamweavers validator does not comment on these. In fact Dreamweaver shows no validation errors for the whole site.

One problem i cant seem to over come is that the #container wont fill the page if the #navcontainer stretches further down the page than the #container content. Any ideas on this? I've tried floating, height 100% but no joy. :roll:

Thanks for the help in advance.

Cheers
J Cool

thepineapplehead
thepineapplehead's picture
Offline
Guru
Last seen: 31 weeks 3 days ago
Joined: 2004-06-30
Posts: 9668
Points: 801

Re: My first CSS site - Really pleased with it. Any comments

camel80 wrote:
These bring up validation errors saying the elements have already been defined. However Dreamweavers validator does not comment on these. In fact Dreamweaver shows no validation errors for the whole site.

That's because Dreamweaver is rubbish, and you're relying on it to do your work for you.

Validate at validator.w3.org and nothign else. And for the love of Pete DO NOT TEST IN DREAMWEAVER'S PREVIEW PANE.

For the validation errors, go here:

http://www.csscreator.com/css-forum/ftopic10633.html

Verschwindende wrote:
  • CSS doesn't make pies

camel80
Offline
newbie
Last seen: 14 years 32 weeks ago
Joined: 2006-03-15
Posts: 8
Points: 0

My first CSS site - Really pleased with it. Any comments?

Thanks for the tip. I'm not sure of the 'already defined' elements otherwise i could have solved these. Can i simply delete the ids since there is no reference to them in my css?

thepineapplehead
thepineapplehead's picture
Offline
Guru
Last seen: 31 weeks 3 days ago
Joined: 2004-06-30
Posts: 9668
Points: 801

My first CSS site - Really pleased with it. Any comments?

If they're not refernced by anything in the CSS, then yes you can Laughing out loud

Nice site by the way; have you experimented with setting the body background to fixed? Might give it a nice edge.

Verschwindende wrote:
  • CSS doesn't make pies

camel80
Offline
newbie
Last seen: 14 years 32 weeks ago
Joined: 2006-03-15
Posts: 8
Points: 0

My first CSS site - Really pleased with it. Any comments?

Cheers for the help. i've done a full validation and sorted out all the errors. Dreamweavers validation is crap. It missed loads.

Also found a major error in my css.

Anyone else got any comments about the site? Laughing out loud

tecniche
Offline
newbie
UK
Last seen: 13 years 51 weeks ago
UK
Joined: 2006-03-16
Posts: 3
Points: 0

My first CSS site - Really pleased with it. Any comments?

camel80 wrote:

Anyone else got any comments about the site? Laughing out loud

Nice looking site!

My only comments are:

The text size defined in px (I assume). To me the text is a little too small and I cannot make it any larger, please do not remove accessibility choices from users.

In IE5 the menu breaks out of the main flow and hangs to the left, about 100px from the top. It wraps over the main content/text in the middle.

camel80 wrote:

One problem i cant seem to over come is that the #container wont fill the page if the #navcontainer stretches further down the page than the #container content. Any ideas on this? I've tried floating, height 100% but no joy.

A very common problem with CSS and IE. I usually cheat and use a background image in a wrapper div that surrounds both #container and #navcontainer. I don't know is anyone else has a better idea, but this seems to be the normal "fix".

ABCruz
ABCruz's picture
Offline
Enthusiast
Pilipinas
Last seen: 6 years 25 weeks ago
Pilipinas
Timezone: GMT+8
Joined: 2005-06-16
Posts: 279
Points: 0

My first CSS site - Really pleased with it. Any comments?

Hello. Good looking site you have there, at first glance. When I finally got to reading the content, I found it hard to focus on anything. I think there are too many "background noises" that are vying for attention. And I'm not entirely sure if grey and blue go well together. Just a few thoughts. Laughing out loud

I am a Man of Truth.
I am a Free Human Person.
I am a Peacemaker.

http://www.abcruz.com

DrP
Offline
Regular
Last seen: 14 years 10 weeks ago
Joined: 2005-12-04
Posts: 48
Points: 0

My first CSS site - Really pleased with it. Any comments?

Isn't most of this site grey and blue?

I really like your site. You've presented it well for the type of content you're providing.

Perhaps the text should be bigger though, as you are presenting most of your information that way. I increased the size of the text twice in Firefox and found that about right on my 1024 x 768 screen.

thepineapplehead
thepineapplehead's picture
Offline
Guru
Last seen: 31 weeks 3 days ago
Joined: 2004-06-30
Posts: 9668
Points: 801

My first CSS site - Really pleased with it. Any comments?

I'd reconsider the tab containing "contact us | news" as with a few text-increases, it goes all over the page. Also, I don't like the fixed width too much - if the text is expanded, I'd like to see the container expand a bit as well.

And if I were you, I'd tewak the search box - the magnifying glass isn;t that obvious that it searches. Maybe something like the input box, then a go button saying "search trailings.info"?

Verschwindende wrote:
  • CSS doesn't make pies

camel80
Offline
newbie
Last seen: 14 years 32 weeks ago
Joined: 2006-03-15
Posts: 8
Points: 0

My first CSS site - Really pleased with it. Any comments?

Thanks for the tips. I realised over the weekend the problem with the contactus/news tab when the text sixe is increased. I'll look into this together with the magnifying glass.

Also, i kinda agree about the blue navigation. I might try it a shade darker.

For those interested i found a nice link to standalone version of IE that can run from a folder.

http://browsers.evolt.org/?ie/32bit/standalone

These helped me a lot when testing.

Also. browsershots.org have a neat little website for testing in other types of browser.

Cheers
J

thepineapplehead
thepineapplehead's picture
Offline
Guru
Last seen: 31 weeks 3 days ago
Joined: 2004-06-30
Posts: 9668
Points: 801

My first CSS site - Really pleased with it. Any comments?

Hehehehe, there's IE3 and 5.01 there as well. I might give em a go Tongue

Verschwindende wrote:
  • CSS doesn't make pies