5 replies [Last post]
global-hans
Offline
newbie
Netherlands, Tiel
Last seen: 16 years 3 weeks ago
Netherlands, Tiel
Joined: 2006-01-06
Posts: 8
Points: 0

I have been working really hard on this website and would like to know what you think about it at this moment

Everything validates but the css can use some cleaning up i think. I have used the lichtbox js script for the gallery. There is supposed to be an image in the top rightcorner but not yet uploaded so there will be a little cross in Explorer and Opera.

The site is tested on Mozilla, Opera and Explorer

Please give some hard cirticism because i really want to become a proffesional designer and critics are always welcome.

Also my english on the website is not that good but ok thats acceptable i hope since im dutch Wink

http://home.hccnet.nl/l.v.wijk/global/eng_home.html

Thank you all in forward
Greets Hans

Hugo
Hugo's picture
Offline
Moderator
London
Last seen: 7 years 3 weeks ago
London
Joined: 2004-06-06
Posts: 15668
Points: 2806

The best i can do

It looks like a pretty good job I like the tabs to the side of the header, on a personal note I find the colour pallette a touch insipid, but then again I'm viewing on a TFT Oups the body could do with something just to set of the text it's a little empty looking.

You're wasting the use of your important h1 tag with 'welcome' that's not much use to search engines that like something descriptive and meaningful and that relates to the rest of the body copy.

Your Dtd; your using XHTML 1.1 yet your server response header is delivering text/html unless your planning on content negotiating your response headers you should be using 1.0 not 1.1 .

Hugo.

Before you make your first post it is vital that you READ THE POSTING GUIDELINES!
----------------------------------------------------------------
Please post ALL your code - both CSS & HTML - in [code] tags
Please validate and ensure you have included a full Doctype before posting.
Why validate? Read Me

Ed Seedhouse
Ed Seedhouse's picture
Offline
Guru
Victoria British Columbia
Last seen: 49 weeks 1 day ago
Victoria British Columbia
Timezone: GMT-8
Joined: 2005-12-14
Posts: 3570
Points: 675

The best i can do

While the colours (Canadian, you know) are pretty enough, the result is low-contrast and hard to read for old folks like me, especially if I've forgotten to clean the reading glasses for awhile.

Ed Seedhouse

Posting Guidelines

Watch out! I am carrying irony, sarcasm and satire, and know how to use them.

Mike Cherim
Mike Cherim's picture
Offline
Enthusiast
Nottingham NH
Last seen: 14 years 50 weeks ago
Nottingham NH
Joined: 2005-08-26
Posts: 126
Points: 0

The best i can do

Hello Hans,

Nice work, but you need to do something about navigation, banner, and tabs. They are images and only images and thus need to be backed up so that stuff is available to those not supporting imagery.

Google "CSS Image Replacement" and you'll find the info you need. This is important.

Mike

EDIT: Oh, by the way. This isn't the best you can do. You can do better, and your next site will prove me right. We can't help but to improve. Keep up the good work. Smile

global-hans
Offline
newbie
Netherlands, Tiel
Last seen: 16 years 3 weeks ago
Netherlands, Tiel
Joined: 2006-01-06
Posts: 8
Points: 0

The best i can do

Mike Cherim wrote:
Hello Hans,

Nice work, but you need to do something about navigation, banner, and tabs. They are images and only images and thus need to be backed up so that stuff is available to those not supporting imagery.

Google "CSS Image Replacement" and you'll find the info you need.

I have used a image replacement for those things.
That h1 and menu contains text but is hidden with a span .

<h1><span>Header</span></h1>
h1 {background: url(pic.jpg)}
h1 span{display:none;}

Is this a bad way of doing it? It is the one i find first when viewing google Tongue

Hugo
Hugo's picture
Offline
Moderator
London
Last seen: 7 years 3 weeks ago
London
Joined: 2004-06-06
Posts: 15668
Points: 2806

The best i can do

The technique (FIR) is not considered the best any longer, if you want to follow that route it's better to use text-indent:-9999px to hide the text off to the left of the viewport but still allowing screen readers to access it. Another technique is to loose the span from the h1 set it's height to '0' and overflow hidden then use top padding to force the element to show the background image whilst hiding the text, or retain the span but instead of it spanning text it holds the background and is positioned absolutely withing the h1 set to position relative, the span then masks the text in the h1 if images are not available the text will be viewable.

There are other variations on these techniques all have merits and drawbacks.

Hugo.

Before you make your first post it is vital that you READ THE POSTING GUIDELINES!
----------------------------------------------------------------
Please post ALL your code - both CSS & HTML - in [code] tags
Please validate and ensure you have included a full Doctype before posting.
Why validate? Read Me