9 replies [Last post]
velo
velo's picture
Offline
Enthusiast
Fayettenam
Last seen: 11 years 43 weeks ago
Fayettenam
Timezone: GMT-5
Joined: 2004-11-11
Posts: 181
Points: 0

Only my second full-on CSS site. The design is deliberately minimalist as per my instructions from the cleint. If you see areas that could use improvement, let the scathing criticism fly.....

Gardall Safe Corporation

FYI- the one item that fails markup validation is that somehow the PHP session id variable is being appended to an included (hardcoded) link. Not seen that before and am going to sort it...I am assuming it is something with my mod_rewrite rules

Give a man a fire and he will be warm for a while. Set a man on fire and he will be warm for the rest of his life.

Anonymous
Anonymous's picture
Guru

Tell me how bad it is....

The list item markers are still on top of the images in Safari.

http://216.74.96.78/page-products-safeType-gun_pistol.htm

This should fix it up without changing anything else:

.borderedPic{
margin:2px 20px 2px 2px;
}

Otherwise it looks great. I am a big fan of minimalist web design as long as it is well balanced (meaning not just two colors and one link Wink ).

velo
velo's picture
Offline
Enthusiast
Fayettenam
Last seen: 11 years 43 weeks ago
Fayettenam
Timezone: GMT-5
Joined: 2004-11-11
Posts: 181
Points: 0

Tell me how bad it is....

I don't have a Safari browser to preview in.....how far into the image are the dots? Would increacsing the margin-left property of my li style kick it over some more or is Safari not seeing the margin-left style at all?

I don't want to mess with the borderedPic style because it will mess with other layouts across the site.

Give a man a fire and he will be warm for a while. Set a man on fire and he will be warm for the rest of his life.

Chris..S
Chris..S's picture
Offline
Moderator
Last seen: 8 years 17 weeks ago
Timezone: GMT+1
Joined: 2005-02-22
Posts: 6078
Points: 173

Tell me how bad it is....

The Session ID is a setting in php.ini. Its the old (original) way of handling session ids, current versions of PHP (should) default to settings which use cookies.

Quote:

; Whether to use cookies.
session.use_cookies = 1

; This option enables administrators to make their users invulnerable to
; attacks which involve passing session ids in URLs; defaults to 0.
session.use_only_cookies = 1

If its a shared server, I'd look at securing the session information in a database with something like php secure sessions (its secure because it moves the session data to your own database which presumably has more restrictive access than the file system - but that particular script does have flaws).

Anonymous
Anonymous's picture
Guru

Tell me how bad it is....

Here's a screenshot

velo
velo's picture
Offline
Enthusiast
Fayettenam
Last seen: 11 years 43 weeks ago
Fayettenam
Timezone: GMT-5
Joined: 2004-11-11
Posts: 181
Points: 0

Tell me how bad it is....

Thanks for the 'shot. Obviously Safari is ignoring the margin-left property of the li tags....

If it's ignoring that style property, how would setting the margin on the img help? Seems like it would ignore both, yes?

I'm just going to remove the session functions from teh site. I only need them in a subdomain.

Thanks

Give a man a fire and he will be warm for a while. Set a man on fire and he will be warm for the rest of his life.

Anonymous
Anonymous's picture
Guru

Tell me how bad it is....

velo wrote:
I don't have a Safari browser to preview in.....how far into the image are the dots? Would increacsing the margin-left property of my li style kick it over some more or is Safari not seeing the margin-left style at all?

I don't want to mess with the borderedPic style because it will mess with other layouts across the site.It is measuring the left margin from the edge of the container and not the picture. You would have to add a left margin large enough to take the picture into consideration or go back to list-style:inside and live with the text wrapping under the bullet. Also does using align="left" attribute validate in 4.01?

velo
velo's picture
Offline
Enthusiast
Fayettenam
Last seen: 11 years 43 weeks ago
Fayettenam
Timezone: GMT-5
Joined: 2004-11-11
Posts: 181
Points: 0

Tell me how bad it is....

Triumph wrote:
Also does using align="left" attribute validate in 4.01?

yes, it does

Give a man a fire and he will be warm for a while. Set a man on fire and he will be warm for the rest of his life.

ABCruz
ABCruz's picture
Offline
Enthusiast
Pilipinas
Last seen: 6 years 37 weeks ago
Pilipinas
Timezone: GMT+8
Joined: 2005-06-16
Posts: 279
Points: 0

Tell me how bad it is....

Hi there, I just took a quick look at your site and it's not bad at all-- except maybe for the fact that it's still laid-out using tables. Smile

I am a Man of Truth.
I am a Free Human Person.
I am a Peacemaker.

http://www.abcruz.com

velo
velo's picture
Offline
Enthusiast
Fayettenam
Last seen: 11 years 43 weeks ago
Fayettenam
Timezone: GMT-5
Joined: 2004-11-11
Posts: 181
Points: 0

Tell me how bad it is....

Quote:
except maybe for the fact that it's still laid-out using tables.

Complex graphics layouts not using tables are not something I am confident enough in using to employ in a production site. Hence tables for the banner graphics and CSS-based layouts for the rest.

Give a man a fire and he will be warm for a while. Set a man on fire and he will be warm for the rest of his life.