12 replies [Last post]
abrichardson
abrichardson's picture
Offline
Regular
chattanooga, TN
Last seen: 11 years 43 weeks ago
chattanooga, TN
Timezone: GMT-5
Joined: 2005-12-13
Posts: 36
Points: 0

I've learned quite a bit from different sources and I'm hoping what I have looks good.

http://69.241.130.104/testSite/setupintro.php
and
http://69.241.130.104/testSite/headstock.php

Could I get some strong feedback on my work? I'd like to know how the two pages look, how good the coding is, and how the css sheet looks Laughing out loud

Thanks

Save a reef.

DanA
DanA's picture
Offline
Elder
Last seen: 9 years 30 weeks ago
Timezone: GMT+2
Joined: 2004-08-14
Posts: 1087
Points: 2

Please evaluate my work?

To validate your html, have a look there :
http://www.alistapart.com/articles/flashsatay/
Then, simplify your css and use the css validator.

abrichardson
abrichardson's picture
Offline
Regular
chattanooga, TN
Last seen: 11 years 43 weeks ago
chattanooga, TN
Timezone: GMT-5
Joined: 2005-12-13
Posts: 36
Points: 0

Please evaluate my work?

The xhtml and css have both been validated at w3c Wink

Save a reef.

abrichardson
abrichardson's picture
Offline
Regular
chattanooga, TN
Last seen: 11 years 43 weeks ago
chattanooga, TN
Timezone: GMT-5
Joined: 2005-12-13
Posts: 36
Points: 0

Please evaluate my work?

I should mention though that the flash part is a new addition and won't be permanant so i'm not worried about that part Laughing out loud

Save a reef.

magburner
Offline
Regular
Last seen: 12 years 21 weeks ago
Joined: 2005-12-09
Posts: 17
Points: 0

Please evaluate my work?

hey! i like your site style. nice layout. im no expert, but ive noticed a minor error, i might be wrong though. on your setup intro page, the second paragraph has a different background to the rest of the page, is there a reason for that? IMO it spoils the image of the guitar you have in the corner.

i like your head stock area page too, particularly the images that have the '?' when the mouse is over them. i take it they will lead to individual pages eventually?

Laughing out loud

abrichardson
abrichardson's picture
Offline
Regular
chattanooga, TN
Last seen: 11 years 43 weeks ago
chattanooga, TN
Timezone: GMT-5
Joined: 2005-12-13
Posts: 36
Points: 0

Please evaluate my work?

[email protected]! The question marks actually indicate that they are acronyms. That's confusing, huh? maybe I should change that?

the intro and headstock pages are pretty much the only two that are completed Sad

Thanks for the feedback. This is my first attempt at xhtml/css driven design. It's not the hardest but it's not the easiest LOL

Save a reef.

fatfreddy
fatfreddy's picture
Offline
Enthusiast
Deep down under
Last seen: 12 years 20 weeks ago
Deep down under
Timezone: GMT+8
Joined: 2005-03-25
Posts: 390
Points: 0

Please evaluate my work?

abrichardson

I agree with the comment about the fretboard background image for para's 2 -4 etc.

I see what you're trying to do but take it away and the text sits better over the guitar image

Also, the intonation page doesn't link to the CSS file (or at least it showed up unstyled when i visited the link?)

Also, in the 'Christmas' version, in FF the text sits over the title background image - you need to add a margin to the main text section

JUst fiddling with it, i added

h2{margin-top:110px;}
.main{margin-top:20px;}

#pageHeader {
background-image: url(img/christmas/leavesandberries1.gif);
height: 110px;
width: 467px;
margin: 0px;
padding: 0px;
position:absolute;}

That sorted out the text overlying the background im age problem in FF - didn't manage to check in IE

HTH

freddy

The only reason for time is so that everything doesn't happen at once
--Albert Einstein

Accessible webdesign Australia - webechodesigns

abrichardson
abrichardson's picture
Offline
Regular
chattanooga, TN
Last seen: 11 years 43 weeks ago
chattanooga, TN
Timezone: GMT-5
Joined: 2005-12-13
Posts: 36
Points: 0

Please evaluate my work?

Thanks a ton! I'll look at that and make the changes you've suggested. I really like this forum cause I've not only gained knowledge, I've gotten to expand my thoughts by getting some good feedback:D

Save a reef.

fatfreddy
fatfreddy's picture
Offline
Enthusiast
Deep down under
Last seen: 12 years 20 weeks ago
Deep down under
Timezone: GMT+8
Joined: 2005-03-25
Posts: 390
Points: 0

Please evaluate my work?

just to add -

i was lazy and although declared position:absolute;
i didn't declare where

you need to add top:0; or top:10px;

to place it correctly

Freddy

Glad it helped Smile

The only reason for time is so that everything doesn't happen at once
--Albert Einstein

Accessible webdesign Australia - webechodesigns

ABCruz
ABCruz's picture
Offline
Enthusiast
Pilipinas
Last seen: 5 years 31 weeks ago
Pilipinas
Timezone: GMT+8
Joined: 2005-06-16
Posts: 279
Points: 0

Please evaluate my work?

Hi there.

I think the templates in black have a lot of potential; I just don't think you're using a good shade of green for your text.

With regard to the paragraphs that have a fretboard background, it seems to be a forced mixture of elements-- either because of the awkward green shade or the background image itself. If I may make a suggestion: why not just crop a fretboard between, say, 4 crutches (so you get a dot in the middle fret); then have your background image repeat horizontally (repeat-x). In that way, no matter how long your paragraphs are, you have a consistent-looking fret board. It would also help if the image was desaturated and darkened if you really want to keep the green text.

But I love the top-left graphic that you have there. I looks fun to work a design around. Cheers! Laughing out loud

I am a Man of Truth.
I am a Free Human Person.
I am a Peacemaker.

http://www.abcruz.com

abrichardson
abrichardson's picture
Offline
Regular
chattanooga, TN
Last seen: 11 years 43 weeks ago
chattanooga, TN
Timezone: GMT-5
Joined: 2005-12-13
Posts: 36
Points: 0

Please evaluate my work?

ABCruz, what shade of green would you recommend?

Save a reef.

abrichardson
abrichardson's picture
Offline
Regular
chattanooga, TN
Last seen: 11 years 43 weeks ago
chattanooga, TN
Timezone: GMT-5
Joined: 2005-12-13
Posts: 36
Points: 0

Please evaluate my work?

Thanks everyone for the feedback. I believe I have the site where I'm satisfied with it.

I only hope I've used a good foundation upon which I can build upon.

http://69.241.130.104/testSite/setupintro.php

I still have one question and it's about tables. xHtml strict will not validate with a table in the code, right? Then why do I see some here saying that tables are fine for tabular data? Is this an oversight of the W3C?

Save a reef.

DanA
DanA's picture
Offline
Elder
Last seen: 9 years 30 weeks ago
Timezone: GMT+2
Joined: 2004-08-14
Posts: 1087
Points: 2

Please evaluate my work?

Quote:
xHtml strict will not validate with a table in the code, right?

It will validate.
Some iFrames content won't !!!