16 replies [Last post]
ale.negrini
Offline
newbie
shelton, USA
Last seen: 14 years 5 weeks ago
shelton, USA
Timezone: GMT-5
Joined: 2005-11-01
Posts: 5
Points: 0

hi,
this is my first css site, and I would like some comments on the css code in order to improve it.

http://www.dmdne.com

If you have any comment on anything else feel free to express it, any comment is welcome.
Thanks in advance.

n8gz4ez
n8gz4ez's picture
Offline
Leader
Last seen: 10 years 45 weeks ago
Timezone: GMT-6
Joined: 2005-06-13
Posts: 802
Points: 0

css review

Something is going with your footer in Firefox, you are using absolute positioning on everything, which has downfalls.

edit: check out Tyssen's write up here:

http://www.csscreator.com/css-forum/ftopic13756.html

This is my big chance . . . yep, I blew it . . .

HellsBells
HellsBells's picture
Offline
Leader
Bedford, UK
Last seen: 11 years 32 weeks ago
Bedford, UK
Joined: 2004-04-07
Posts: 851
Points: 0

css review

Hi

Just had a quick look. Couple of things that I'd look at:

I'd make your main navigation a list and apply the flower images as background images for your links rather than add them into separate <divs>.

Here's a site with fuller explanation of the techniques: http://css.maxdesign.com.au/listamatic/ you'll find links to explanations about making the images background images plus making the list display horizontally.

I'd also use %s or ems or keywords for your font sizing rather than pxs as the text won't resize in IE properly.

Related to that issue - you're footer is positioned absolutely at the bottom of the page so when the text is resized in a good browser it overlaps the footer.

Getting the footer at the bottom of the page can be a bit of a pain - but this technique seems to work: http://www.themaninblue.com/writing/perspective/2005/08/29/

My strategy is so simple an idiot could have devised it!

"Also, your CSS (no offence) makes me want to gouge my eyes out with a rusty spoon" - TPH

http
http's picture
Offline
Regular
Last seen: 14 years 6 weeks ago
Joined: 2005-10-29
Posts: 13
Points: 0

css review

HellsBells wrote:

Getting the footer at the bottom of the page can be a bit of a pain - but this technique seems to work: http://www.themaninblue.com/writing/perspective/2005/08/29/

I also found this revision useful:

http://www.1cog.com/public/footer.html

ale.negrini
Offline
newbie
shelton, USA
Last seen: 14 years 5 weeks ago
shelton, USA
Timezone: GMT-5
Joined: 2005-11-01
Posts: 5
Points: 0

css review

I will look at the footer and I will try to change positions from absolute to relataive.
Thanks for giving me directions on the navigation bar, I had problems finding the right way to implement it.

ale.negrini
Offline
newbie
shelton, USA
Last seen: 14 years 5 weeks ago
shelton, USA
Timezone: GMT-5
Joined: 2005-11-01
Posts: 5
Points: 0

css code review - revision 1

Hi,
after your comments (extremely useful) I have modified the code.
How is it now?

http://www.dmdne.com

Thanks in advance

n8gz4ez
n8gz4ez's picture
Offline
Leader
Last seen: 10 years 45 weeks ago
Timezone: GMT-6
Joined: 2005-06-13
Posts: 802
Points: 0

css review

"Site Design by Webspace Technologies" is near
impossible to read.

This is my big chance . . . yep, I blew it . . .

ClevaTreva
ClevaTreva's picture
Offline
Guru
A hilly place, UK
Last seen: 1 year 5 weeks ago
A hilly place, UK
Joined: 2004-02-05
Posts: 2902
Points: 0

css review

n8gz4ez wrote:
"Site Design by Webspace Technologies" is near
impossible to read.

Looks OK to me Tongue

thepineapplehead
thepineapplehead's picture
Offline
Guru
Last seen: 1 year 16 weeks ago
Timezone: GMT+1
Joined: 2004-06-30
Posts: 9668
Points: 801

css review

I don't know what you mean, I can see it fine :roll:

Verschwindende wrote:
  • CSS doesn't make pies

n8gz4ez
n8gz4ez's picture
Offline
Leader
Last seen: 10 years 45 weeks ago
Timezone: GMT-6
Joined: 2005-06-13
Posts: 802
Points: 0

css review

:twisted: Do I have an evil shadow?

Black text on dark blue is hard to read.

edit: ok, I get it :oops:

This is my big chance . . . yep, I blew it . . .

ale.negrini
Offline
newbie
shelton, USA
Last seen: 14 years 5 weeks ago
shelton, USA
Timezone: GMT-5
Joined: 2005-11-01
Posts: 5
Points: 0

css review

do you still have problem reading : site design by webspace technology? it is supposed to be over the blue space.

What do you think of the css code now?
Anything else I can improve?

thanks

thepineapplehead
thepineapplehead's picture
Offline
Guru
Last seen: 1 year 16 weeks ago
Timezone: GMT+1
Joined: 2004-06-30
Posts: 9668
Points: 801

css review

ale.negrini wrote:
do you still have problem reading : site design by webspace technology? it is supposed to be over the blue space.

What do you think of the css code now?
Anything else I can improve?

thanks

<link rel="stylesheet" type="text/css" href="DMD_Publication distribution, brochures, flyers, newspapers at DMD, CT, MA, RI, Connecticut, Mass, VT, NH_files/_index.css">
<style type="text/css">

I think you broke it Laughing out loud

Verschwindende wrote:
  • CSS doesn't make pies

Anonymous
Anonymous's picture
Guru

css review

thepineapplehead wrote:
<link rel="stylesheet" type="text/css" href="DMD_Publication distribution, brochures, flyers, newspapers at DMD, CT, MA, RI, Connecticut, Mass, VT, NH_files/_index.css">
<style type="text/css">

I think you broke it Laughing out loudI was going to post about that url but decided against it because, surprisingly, it works. Laughing out loud

I think there are more characters in the url than in the css file itself. Wink

ClevaTreva
ClevaTreva's picture
Offline
Guru
A hilly place, UK
Last seen: 1 year 5 weeks ago
A hilly place, UK
Joined: 2004-02-05
Posts: 2902
Points: 0

css review

thepineapplehead wrote:
I don't know what you mean, I can see it fine :roll:

Hey when I looked at the site, the text was ABOVE the blue line! Hence it was easy to see!

n8gz4ez
n8gz4ez's picture
Offline
Leader
Last seen: 10 years 45 weeks ago
Timezone: GMT-6
Joined: 2005-06-13
Posts: 802
Points: 0

css review

ClevaTreva wrote:
Hey when I looked at the site, the text was ABOVE the blue line! Hence it was easy to see!

And here I thought I was being hoodwinked. Tongue

This is my big chance . . . yep, I blew it . . .

ale.negrini
Offline
newbie
shelton, USA
Last seen: 14 years 5 weeks ago
shelton, USA
Timezone: GMT-5
Joined: 2005-11-01
Posts: 5
Points: 0

css review

Problem:
"design by webspace technology" overlaps the blue area only with FF, not with IE.
Two grey areas appears: above the navigationbar and above the footer. FF, not IE.

I can not fix them. Anybody has an idea?
Thanks

Mike Cherim
Mike Cherim's picture
Offline
Enthusiast
Nottingham NH
Last seen: 12 years 43 weeks ago
Nottingham NH
Joined: 2005-08-26
Posts: 126
Points: 0

css review

Hard for me to see, let alone read Wink

I think the site looks okay, but it begs for more typograhic style. A bit on the plain side.

Usability-wise, my nit-pickiness aside, I think it's good.

Good luck.
Mike