7 replies [Last post]
Red Matrix
Red Matrix's picture
Offline
Regular
RGV
Last seen: 13 years 16 weeks ago
RGV
Timezone: GMT-5
Joined: 2005-09-17
Posts: 24
Points: 0

I think I got everything just right... so could someone check it out and tell me what you think of my markup, and CSS? (and overal design)

Thanks.

Valley Club Poker

PS: Be sure to click on the "laredo" link, and sub sequent tabs! Smile

Dave

drhowarddrfine
Offline
Leader
Last seen: 12 years 37 weeks ago
Timezone: GMT-6
Joined: 2005-05-21
Posts: 764
Points: 0

I think I got everything just right

You should run it through the validators and clean up your errors but it's not too far out of line.

IE7 is 10 years behind the standards or wrong.
But it works in IE!
IE is a cancer on the web -- Paul Thurott

larmyia
Offline
Elder
London
Last seen: 13 years 48 weeks ago
London
Timezone: GMT+1
Joined: 2005-01-25
Posts: 1060
Points: 0

I think I got everything just right

yes, you really need to validate your html and css.

aside from that on the Laredo site you know there are no members? when on "schedule" the <p> on the right (in the red) goes outside the lines of the red background.

on the normal site...why when you go to "gallery" does the layout of the page change from all your other pages? I don't really see the point and continuity is important on a site.

you've got some css styling on you xhtml page, and I am not sure why this isn't in your main css page. a minor point I'm sure....but still....

I'm assuming you have no control over the flashing ad on the left? it's very distracting and annoying.

also, I don't think your hover works very well graphically.

anyway, just a few thoughts.

larmyia

Red Matrix
Red Matrix's picture
Offline
Regular
RGV
Last seen: 13 years 16 weeks ago
RGV
Timezone: GMT-5
Joined: 2005-09-17
Posts: 24
Points: 0

ty

Thanks for your input.

#1... that ad on the left *is* annoying, but they want it. There are no static ads to choose from either.

#2... the gallery page was done by another individual. It didn't even go well with the previous FRAMES layout. (yikes)

#3... the laredo site is up and comming, but I did forget to copypaste the members into the page. Shock

#4... last time I checked, i only had 1 validation error on the HTML side. As for the CSS... i am at a loss for words.

#5... when you say my hover doesn't work graphically, are you talking about the darkness of the color?

#6... the <p> on the right?... I guess I didn't change the laredo.css file when i fixed the original css file! :oops:

Dave

larmyia
Offline
Elder
London
Last seen: 13 years 48 weeks ago
London
Timezone: GMT+1
Joined: 2005-01-25
Posts: 1060
Points: 0

I think I got everything just right

you get 7 xhtml validation errors and several warnings. whenever you make a change you need to validate, as you might accidentily change something else...

because your xhtml doesn't validate then I can't check you css without saving it myself etc.

with the hover...imho it just doesn't look right. when you hover it blocks out the black bottom border, and when you hover next to the current page, it just...well doesn't look right.

at the end of the day if you like it keep it, it's just my opinion...

good luck

larmyia

Red Matrix
Red Matrix's picture
Offline
Regular
RGV
Last seen: 13 years 16 weeks ago
RGV
Timezone: GMT-5
Joined: 2005-09-17
Posts: 24
Points: 0

I think I got everything just right

... and your opinion is greatly appreciated!

I am still new to Divisions and Stylesheets.
I know HTML, though. I just wish I could
take the convenience of frames and plop it
onto DIVs. If I need to change something
small on a header... I don't want to have to
do it on 5 to 7 .html pages. Crying

Dave

larmyia
Offline
Elder
London
Last seen: 13 years 48 weeks ago
London
Timezone: GMT+1
Joined: 2005-01-25
Posts: 1060
Points: 0

I think I got everything just right

in that case I guess you could think about server side includes. I am not very ofey with them, but I understand it's not hard and would prob just mean some php (or something of that sort). there are plenty of ppl on here that could advise you better. just google SSI for more info.

at the end of the day changing it on 7 pages is a pain but doable, but if you're going to get into larger sites I think SSI are the way to go.

I think css, divs, id/classes and all that are more of a mental leap. trust me, once you get it you'll wonder how you ever did anything with frames!

larmyia

Tyssen
Tyssen's picture
Offline
Moderator
Brisbane
Last seen: 7 years 44 weeks ago
Brisbane
Timezone: GMT+10
Joined: 2004-05-01
Posts: 8201
Points: 1386

I think I got everything just right

larmyia wrote:
in that case I guess you could think about server side includes. I am not very ofey with them, but I understand it's not hard and would prob just mean some php (or something of that sort). there are plenty of ppl on here that could advise you better. just google SSI for more info.

Server side includes are very easy to use and save a lot of work/time.
Basically, you take the piece of code (it can be HTML, ASP, PHP etc.) you want to use in multiple locations, cut it out from the file where it currently exists and paste it into a new file.
Then in the file it was removed from, you'd do this:

PHP
<?php include ("/nameofyourfile.php"); ?>

ASP & SHTML
<!--#include file="nameofyourfile.asp" -->
for relatively linked files or
<!--#include virtual="/nameofyourfile.asp" -->
for absolute links.
You don't have to link to a PHP file in PHP and an ASP file in ASP, you can link to .htm, .txt or .inc files too (for example). You won't be able to link to an ASP file in PHP and vice versa though.
Not all servers have SSI set up by default, but most will. If you can run either PHP or ASP, you can run SSI and some HTML-only servers will let you to use SSI as well.

How to get help
Post a link. If you can't post a link, jsFiddle it.
My blog | My older articles | CSS Reference