1 reply [Last post]
YYZFAN
YYZFAN's picture
Offline
newbie
USA
Last seen: 3 years 38 weeks ago
USA
Timezone: GMT-5
Joined: 2011-01-29
Posts: 1
Points: 2

Hello,

Thank you for taking the time to review my CSS and offer suggestions....

Background:
It is the combination of two graphic designs. I could only get the home page / logo / header done. The rest of the site was my "guess" on what the graphic designers would have done.

I did most of the PSD to CSS. The PSD to HTML was done by development team. They did the initial CSS. They are a big fan of the 960grid system. I was at first, but when I realized you can do more with straight up display / position etc.... I'm moving away. I've been learning CSS for the last 6 months or so... I'm in love....

Link to the "main" css file...

http://market-media.greatcoins.com.s3.amazonaws.com/media/css/style.css

I'm looking for criticism on consistency, fonts, spacing, layout, optimization. I think I'm ok with cross platform. I develop on chrome / safari. I test on XP with IE 8.

I realize a few things:
My CSS is spaghetti code. Due to the lack of classes on each page, i have to do a lot to get specfiic on elements for design. I have not properly documented my CSS file, I"m in the process of ordering it and commenting it properly.

The more CSS I do the more I hate IE. plain and simple...

Thanks

YYZ FAN (no not the air port)

Verschwindende
Verschwindende's picture
Offline
Guru
Last seen: 2 weeks 5 days ago
Timezone: GMT-4
Joined: 2009-10-09
Posts: 2037
Points: 2259

I'm not sure if you want me

I'm not sure if you want me to look at the site in the thread title or just the CSS so I did both. Considering the simplicity of the layout in the site I'd say the CSS is unnecessarily convoluted. The markup wasn't much better, total divitis.

Maybe all those unnecessary divs are required by this grid system you mention and if so, I agree with you, I'm not a fan.

If the live site is not the one we're talking about perhaps moving this to "CSS Layouts" instead of "Site Checks" along with a copy of the PSD would be in order.