7 replies [Last post]
jckpalmer
Offline
Regular
UK
Last seen: 6 years 1 week ago
UK
Joined: 2008-07-10
Posts: 34
Points: 0

Hello,

Just finished the code for my custom ecommerce project.

Can you cast your professional eye's across these pages and give me your opinions, critique and any comments.

I would also like any tips / code pointers for making the code cross-compatible, accessable and correctly formatted for w3c.

I've chekced the CSS on w3c there's a small error I can't sort out...some sort of parse error??? Other than that, any other comments or advice for making the CSS more efficient?

http://lunar.etopians.com

There's also a little bit in the "enteded tabs 2" divs that needs a bit of work if anyone can give me a quick solution to solve the width / spacing issue. Looks cramped up to the left.

Appreciate it, guys.

Thanks.

(also if anyone would like to acquire the use of this software I am open to offers...PM me.)

id="css"
#css {
background:too tired for this!
}

David Laakso
David Laakso's picture
Offline
Enthusiast
US
Last seen: 5 years 49 weeks ago
US
Joined: 2008-07-18
Posts: 265
Points: 0

Regarding the w3c CSS

Regarding the w3c CSS validation service throwing an error:

You have this:

#product_details_entended_tabs3 {
float:left;
width:100px;
padding-top:10px;
background-color:black;}/*

/*.product_image { /* product image for the details section
height:200px;
}*/

#main_right { /* Main right content container */
float:right;
background-color:#FF0000;
width:150px;
height:50px;
}

I /think/ you may want only this:

#product_details_entended_tabs3 {
float:left;
width:100px;
padding-top:10px;
background-color:black;}

#main_right { /* Main right content container */
float:right;
background-color:#FF0000;
width:150px;
height:50px;
}

jckpalmer
Offline
Regular
UK
Last seen: 6 years 1 week ago
UK
Joined: 2008-07-10
Posts: 34
Points: 0

Error

Thank you, I notice the error now.

Can anyone offer any code changes re: the warnings? Or will the code now be ok to mark as w3c CSS compliant?

Jckpalmer

id="css"
#css {
background:too tired for this!
}

David Laakso
David Laakso's picture
Offline
Enthusiast
US
Last seen: 5 years 49 weeks ago
US
Joined: 2008-07-18
Posts: 265
Points: 0

What warnings? Mark as w3c

What warnings?

Mark as w3c CSS compliant? Depends on where you intend to "mark" it, I suppose. If you mean mark it for "your eyes only," sure-- why not. Marking it as w3c CSS compliant on a document whose markup is not valid may be setting yourself up for a world of grief.

Whether sites having both CSS and valid (X)HTML should include marking same on the document, is a matter of opinion. /Personally,/ I think not.

jckpalmer
Offline
Regular
UK
Last seen: 6 years 1 week ago
UK
Joined: 2008-07-10
Posts: 34
Points: 0

Marky Mark

What warnings?

Here: http://jigsaw.w3.org/css-validator/validator?uri=lunar.etopians.com&profile=css21&usermedium=all&warning=1&lang=en

26 warnings.

I intended to mark it where everyone else does at the bottom of the page. With the following logo:

The document is CSS comliant to level 2.1 according to the w3c standards? So I wouldn't be in a world of grief. I mean why wouldn't you brag to your customers and clients that the code you've created is w3c CSS compliant?

The XHTML in this site may not be complaint YET but as previously explained in another thread.../twice/...I am not the coder in that area, I code CSS only.

I am not in charge of the PHP / XHTML and will be posting the site onto a forum similar to this one to deal with any XHTML issues.

I don't quite understand what you meant in your last paragraph if you could rewrite it I'd appreciate it? I presume you mean if its not BOTH css AND XHTML complaint don't bother putting the logo's on?

would appreciate a rewrite on that bit David.

Regards

jckpalmer

id="css"
#css {
background:too tired for this!
}

David Laakso
David Laakso's picture
Offline
Enthusiast
US
Last seen: 5 years 49 weeks ago
US
Joined: 2008-07-18
Posts: 265
Points: 0

If you are completely

If you are completely confident (done enough testing) that none of the warnings adversely effect your page, then ignore the warnings. In other words, the CSS is valid with or without warnings. The CSS is valid whether or not you declare so on the document; and, the CSS is valid regardless of whether or not the (X)HTML is valid.

Whatever scenario you wish to come up with, the CSS is valid-- give yourself a gold star. If the (X)HTML were valid-- give yourself another gold star. Put the gold star(or both gold stars); and, the w3c validation logo (or both validation logos), in the garbage can or a dumpster.

Make a committed effort to remember, not to forget, that you are a pro, not an amateur.

jasonglades
Offline
newbie
Last seen: 5 years 12 weeks ago
Joined: 2009-05-07
Posts: 1
Points: 0

I must say very informative

This comment has been moved here.

briannew220
Offline
newbie
USA
Last seen: 5 years 4 days ago
USA
Joined: 2009-07-29
Posts: 1
Points: 0

Writing service

This comment has been moved here.