8 replies [Last post]
nick_e
Offline
newbie
Last seen: 8 years 41 weeks ago
Joined: 2005-11-10
Posts: 1
Points: 0

Hi,

I'm pretty much done with this website I've been working on for a while.

If a couple people could check out the front page of the site and make sure the graphics aren't broken up or getting lines in them or anything that would be awsome.

If you check around the inner pages for errors that would be awsome but I only really need the front page checked.

**** Link Removed ****

warning - large, horribly bloated HTML follows

<html>
<head>
<title>MyGuitarObsession.com</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<script language="JavaScript" type="text/JavaScript">
<!--
function MM_swapImgRestore() { //v3.0
  var i,x,a=document.MM_sr; for(i=0;a&&i<a.length&&(x=a[i])&&x.oSrc;i++) x.src=x.oSrc;
}

function MM_preloadImages() { //v3.0
  var d=document; if(d.images){ if(!d.MM_p) d.MM_p=new Array();
    var i,j=d.MM_p.length,a=MM_preloadImages.arguments; for(i=0; i<a.length; i++)
    if (a[i].indexOf("#")!=0){ d.MM_p[j]=new Image; d.MM_p[j++].src=a[i];}}
}

function MM_findObj(n, d) { //v4.01
  var p,i,x;  if(!d) d=document; if((p=n.indexOf("?"))>0&&parent.frames.length) {
    d=parent.frames[n.substring(p+1)].document; n=n.substring(0,p);}
  if(!(x=d[n])&&d.all) x=d.all[n]; for (i=0;!x&&i<d.forms.length;i++) x=d.forms[i][n];
  for(i=0;!x&&d.layers&&i<d.layers.length;i++) x=MM_findObj(n,d.layers[i].document);
  if(!x && d.getElementById) x=d.getElementById(n); return x;
}

function MM_swapImage() { //v3.0
  var i,j=0,x,a=MM_swapImage.arguments; document.MM_sr=new Array; for(i=0;i<(a.length-2);i+=3)
   if ((x=MM_findObj(a[i]))!=null){document.MM_sr[j++]=x; if(!x.oSrc) x.oSrc=x.src; x.src=a[i+2];}
}
//-->
</script>
</head>
<body bgcolor="#000000" leftmargin="0" topmargin="0" marginwidth="0" marginheight="0" onLoad="MM_preloadImages('images/_toolsofthetrade.gif','images/_home.gif','images/_practice.gif','images/_scarystuff.gif','images/_recomendations.gif','images/_metaphysics.gif','images/_archives.gif')">
<table width="1060" height="715" border="0" cellpadding="0" cellspacing="0" bgcolor="#000000" id="Table_01">
  <!--DWLayoutTable-->
  <tr> 
    <td colspan="3" rowspan="2"><!--DWLayoutEmptyCell-->&nbsp; </td>
    <td width="63" rowspan="3"><img src="images/1.gif" name="home" width="63" height="142" border="0"></td>

    <td height="17" colspan="9"> <img src="images/temp_03.gif" width="419" height="17" alt=""></td>
    <td width="1"> <img src="images/spacer.gif" width="1" height="17" alt=""></td>
    <td width="258"></td>
    <td width="1"></td>
  </tr>
  <tr> 
    <td colspan="3" rowspan="5"> <img src="images/temp_04.gif" width="189" height="326" alt=""></td>
    <td width="48" rowspan="3"> <a href="practice/index.html" onMouseOut="MM_swapImgRestore()" onMouseOver="MM_swapImage('Image34','','images/_practice.gif',1)"><img src="images/practice.gif" name="Image34" width="48" height="238" border="0"></a></td>

    <td width="49" rowspan="3" valign="top"><!--DWLayoutEmptyCell-->&nbsp;</td>
    <td width="25" height="84"></td>
    <td width="45"></td>
    <td width="45"></td>
    <td width="18"></td>
    <td></td>
    <td></td>
    <td></td>
  </tr>

  <tr> 
    <td height="41" colspan="3"> <a href="toolsofthetrade/index.html" onMouseOut="MM_swapImgRestore()" onMouseOver="MM_swapImage('toolsofthetrade','','images/_toolsofthetrade.gif',1)"><img src="images/toolsofthetrade.gif" name="toolsofthetrade" width="318" height="41" border="0"></a></td>
    <td colspan="6" rowspan="2" valign="top"><div align="center"><font color="#00CC00" size="5">&quot;I 
        never practice. I open the case once in a while and throw in a piece of 
        meat.&quot;</font><font color="#00CC00" size="4"><br>
        Wes Montgomery</font></div></td>
    <td></td>
  </tr>
  <tr> 
    <td colspan="4" rowspan="5"> <img src="images/temp_08.gif" width="381" height="254" alt=""></td>

    <td height="113"></td>
  </tr>
  <tr> 
    <td height="41" colspan="5"> <a href="/stuff/index.html" onMouseOut="MM_swapImgRestore()" onMouseOver="MM_swapImage('scarystuff','','images/_scarystuff.gif',1)"><img src="images/scarystuff.gif" name="scarystuff" width="212" height="41" border="0"></a></td>
    <td>&nbsp;</td>
    <td>&nbsp;</td>
    <td>&nbsp;</td>
    <td></td>
  </tr>

  <tr> 
    <td height="47" colspan="5" bgcolor="#FFFFCC"><!--DWLayoutEmptyCell-->&nbsp; </td>
    <td>&nbsp;</td>
    <td>&nbsp;</td>
    <td>&nbsp;</td>
    <td></td>
  </tr>
  <tr> 
    <td width="45" rowspan="4" valign="top" bgcolor="#FFFFCC"><!--DWLayoutEmptyCell-->&nbsp;</td>

    <td height="25" colspan="6" valign="top" bgcolor="#FFFFCC"><!--DWLayoutEmptyCell-->&nbsp;</td>
    <td rowspan="4" valign="top" bgcolor="#FFFFCC"><!--DWLayoutEmptyCell-->&nbsp;</td>
    <td>&nbsp;</td>
    <td>&nbsp;</td>
    <td>&nbsp;</td>
    <td></td>
  </tr>
  <tr> 
    <td colspan="6" rowspan="2" valign="top" bgcolor="#FFFFCC"><font size="4" face="Georgia, Times New Roman, Times, serif"><strong><font color="#550000">Like 
      Taking a Shower</font></strong></font><font color="#550000" face="Georgia, Times New Roman, Times, serif"><font size="3"><br>

      Practicing the guitar is like taking a shower.<br> 
	  Think about it. Most people take a shower<br>
	  at least once a <a href="practice/index.html">month...</a><strong><br>
      </strong></font><strong><br>
      <font size="4">A440</font><br>
      </strong>The next time you’re at a bar gig and some<br> drunken fool <a href="toolsofthetrade/index.html">shouts 
      out...</a></font></td>

    <td height="28">&nbsp;</td>
    <td>&nbsp;</td>
    <td>&nbsp;</td>
    <td></td>
  </tr>
  <tr> 
    <td width="18" rowspan="6"><!--DWLayoutEmptyCell-->&nbsp; </td>
    <td width="52" rowspan="3"> <a href="/archives/index.html" onMouseOut="MM_swapImgRestore()" onMouseOver="MM_swapImage('archives','','images/_archives.gif',1)"><img src="images/archives.gif" name="archives" width="52" height="202" border="0"></a></td>

    <td colspan="2" rowspan="5"> <img src="images/temp_15.gif" width="311" height="244" alt=""></td>
    <td height="142">&nbsp;</td>
    <td>&nbsp;</td>
    <td>&nbsp;</td>
    <td></td>
  </tr>
  <tr> 
    <td height="25" colspan="6" valign="top" bgcolor="#FFFFCC"><!--DWLayoutEmptyCell-->&nbsp;</td>
    <td>&nbsp;</td>

    <td>&nbsp;</td>
    <td>&nbsp;</td>
    <td></td>
  </tr>
  <tr> 
    <td colspan="2" rowspan="4"><!--DWLayoutEmptyCell-->&nbsp; </td>
    <td width="242" height="61" colspan="4" rowspan="2"> <a href="recomendations/index.html" onMouseOut="MM_swapImgRestore()" onMouseOver="MM_swapImage('recomendations','','images/_recomendations.gif',1)"><img src="images/recomendations.gif" name="recomendations" width="242" height="61" border="0"></a></td>
    <td colspan="2" rowspan="4"><!--DWLayoutEmptyCell-->&nbsp; </td>

    <td rowspan="4" valign="top"><!--DWLayoutEmptyCell-->&nbsp; </td>
    <td height="35"> <img src="images/spacer.gif" width="1" height="35" alt=""></td>
    <td></td>
    <td></td>
  </tr>
  <tr> 
    <td rowspan="3"><!--DWLayoutEmptyCell-->&nbsp; </td>
    <td height="26"> <img src="images/spacer.gif" width="1" height="26" alt=""></td>

    <td></td>
    <td></td>
  </tr>
  <tr> 
    <td colspan="4" rowspan="2"><!--DWLayoutEmptyCell-->&nbsp; </td>
    <td height="16"> <img src="images/spacer.gif" width="1" height="16" alt=""></td>
    <td></td>
    <td></td>

  </tr>
  <tr> 
    <td height="41" colspan="2"> <a href="metaphysics/index.html" onMouseOut="MM_swapImgRestore()" onMouseOver="MM_swapImage('metaphysics','','images/_metaphysics.gif',1)"><img src="images/metaphysics.gif" name="metaphysics" width="311" height="41" border="0"></a></td>
    <td> <img src="images/spacer.gif" width="1" height="41" alt=""></td>
    <td></td>
    <td></td>
  </tr>
  <tr> 
    <td height="29"></td>

    <td></td>
    <td width="248"></td>
    <td></td>
    <td></td>
    <td width="24"></td>
    <td width="120"></td>
    <td></td>
    <td></td>
    <td></td>

    <td></td>
    <td></td>
    <td></td>
    <td>&nbsp;</td>
    <td></td>
    <td></td>
  </tr>
  <tr> 
    <td height="18" colspan="13" valign="top"><div align="center"><font face="Georgia, Times New Roman, Times, serif"><a href="/contact/index.html"><font color="#FFFF00">Contact</font></a></font></div></td>

    <td></td>
    <td></td>
    <td></td>
  </tr>
  <tr> 
    <td height="1"> <img src="images/spacer.gif" width="18" height="1" alt=""></td>
    <td> <img src="images/spacer.gif" width="52" height="1" alt=""></td>
    <td> <img src="images/spacer.gif" width="248" height="1" alt=""></td>

    <td> <img src="images/spacer.gif" width="63" height="1" alt=""></td>
    <td> <img src="images/spacer.gif" width="45" height="1" alt=""></td>
    <td></td>
    <td> <img src="images/spacer.gif" width="120" height="1" alt=""></td>
    <td> <img src="images/spacer.gif" width="48" height="1" alt=""></td>
    <td> <img src="images/spacer.gif" width="49" height="1" alt=""></td>

    <td></td>
    <td> <img src="images/spacer.gif" width="45" height="1" alt=""></td>
    <td></td>
    <td> <img src="images/spacer.gif" width="18" height="1" alt=""></td>
    <td></td>
    <td></td>
    <td></td>
  </tr>

</table>
</body>
</html>

n8gz4ez
n8gz4ez's picture
Offline
Leader
Last seen: 5 years 30 weeks ago
Timezone: GMT-6
Joined: 2005-06-13
Posts: 802
Points: 0

READ FIRST: How Not To Post A Site Check

Hi Nick,

I checked your site in Firefox and IE for Windows. They look consistent from each other. You have some validation errors, no doctype for starters. Smile

http://validator.w3.org/

I noticed you are using tables for layout, I didn't notice a lick of CSS declared.

This is my big chance . . . yep, I blew it . . .

thepineapplehead
thepineapplehead's picture
Offline
Guru
Milton Keynes
Last seen: 2 weeks 1 day ago
Milton Keynes
Timezone: GMT+1
Joined: 2004-06-30
Posts: 9668
Points: 801

READ FIRST: How Not To Post A Site Check

Sorry, but you fail. :twisted:

Quoted directly from "Before Posting, CLICK HERE":

Tony wrote:
For those posting their site

Before you post your site, please Validate.
Validate your CSS and Markup (HTML or XHTML). A great resource for using the validator can be found here.

The most common mistake with a page is the lack of a doctype. If you don't have one, Pineapple will be the first to let you know Laughing out loud.

Also, remove the XML Prolog. This is the code that starts <xml version="... >. It is unnecessary (unless using an XML file), and causes IE to be thrown into Quirks mode. This is a bad thing. For a demo of how this affects IE, check out this page.

Criticism

Site checks like the rest of the CSS forum are about helping fellow web developers learn and improve. They are not about degrading, criticising or making anyone lose face.

If you are responding to a site check, offer advice or suggestions, encourage, show respect, be constructive not destructive.

If you’ve had a bad day at work don’t take it out on anyone here, turn off your computer, go for a walk turn left at the corner and keep going till you reach the pub, café, park and relax for a while.

Obviously you didn't read that. Therefore, you fail.

Verschwindende wrote:
  • CSS doesn't make pies

Anonymous
Anonymous's picture
Guru

READ FIRST: How Not To Post A Site Check

Does anyone else get a picture of TPH in full habit?

Laughing out loud

Mike Cherim
Mike Cherim's picture
Offline
Enthusiast
Nottingham NH
Last seen: 7 years 27 weeks ago
Nottingham NH
Joined: 2005-08-26
Posts: 126
Points: 0

READ FIRST: How Not To Post A Site Check

Timed out for me when I tried to look.

@thepinapplehead: You weren't the first one as it says Shock

Mike

Anonymous
Anonymous's picture
Guru

READ FIRST: How Not To Post A Site Check

I'm not exactly sure if this is an actual site check or if the forum is being used to bump him up in the search engines.

 <tr> 
    <td width="45" rowspan="4" valign="top" bgcolor="#FFFFCC"><!--DWLayoutEmptyCell-->&nbsp;</td>
    <td height="25" colspan="6" valign="top" bgcolor="#FFFFCC"><!--DWLayoutEmptyCell-->&nbsp;</td>
    <td rowspan="4" valign="top" bgcolor="#FFFFCC"><!--DWLayoutEmptyCell-->&nbsp;</td>
    <td>&nbsp;</td>
    <td>&nbsp;</td>
    <td>&nbsp;</td>
    <td></td>
  </tr>
  <tr> 
He/she obviously hasn't been reading the forum. This is his/her only post. There is also no css or even any inline style atributes, simply tables and font tags. I'm calling BS on this one.

n8gz4ez wrote:
I noticed you are using tables for layout, I didn't notice a lick of CSS declared.
Oops, I see nate already pointed that out. Smile

gary.turner
gary.turner's picture
Offline
Moderator
Dallas
Last seen: 33 min 21 sec ago
Dallas
Timezone: GMT-5
Joined: 2004-06-25
Posts: 9171
Points: 3161

READ FIRST: How Not To Post A Site Check

I suggest removing the link and moving it back to the site check forum in a locked condition.

It should serve as an object lesson.

cheers,

gary

Unplanned code results in a tangled wad of brain-cramping confusion.

There are enough html & css demos and tutorials to be interesting. Please visit.

thepineapplehead
thepineapplehead's picture
Offline
Guru
Milton Keynes
Last seen: 2 weeks 1 day ago
Milton Keynes
Timezone: GMT+1
Joined: 2004-06-30
Posts: 9668
Points: 801

READ FIRST: How Not To Post A Site Check

Moved, stickified, locked and retitled - to serve as a warning for those with site checks.

I've left the link in, in case anyone wants to see how not to code a webpage. I'll remove it if you think it necessary.

Verschwindende wrote:
  • CSS doesn't make pies

Anonymous
Anonymous's picture
Guru

READ FIRST: How Not To Post A Site Check

thepineapplehead wrote:
Moved, stickified, locked and retitled - to serve as a warning for those with site checks.

I've left the link in, in case anyone wants to see how not to code a webpage. I'll remove it if you think it necessary.Just post the markup and delete the link. Smile